Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PWA - Allow CORS and add UseCredentials to nuxt.config.js #4902

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

Borriborri
Copy link
Contributor

What this PR does / why we need it:

This PR updates the crossorigin attribute to use use-credentials as per #3935 and documentation found here.

By enabling this setting, the PWA can be successfully installed behind Cloudflare Access, ensuring compatibility with credential-based authentication mechanisms.

Which issue(s) this PR fixes:

Fixes #3935

Special notes for your reviewer:

Testing

  • Tested the PWA installation process behind Cloudflare Access, confirming successful installation with use-credentials set.

as per issue mealie-recipes#3935 and documentation found here https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/crossorigin#use-credentials

this allows for the PWA to be installed behind cloudflare acces
@Borriborri Borriborri changed the title Allow CORS and add UseCredentials to nuxt.config.js fix: Allow CORS and add UseCredentials to nuxt.config.js Jan 15, 2025
@Borriborri Borriborri changed the title fix: Allow CORS and add UseCredentials to nuxt.config.js fix: PWA - Allow CORS and add UseCredentials to nuxt.config.js Jan 15, 2025
Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@michael-genson michael-genson enabled auto-merge (squash) January 15, 2025 21:11
@michael-genson michael-genson merged commit 07bbda8 into mealie-recipes:mealie-next Jan 15, 2025
13 checks passed
@Borriborri Borriborri deleted the patch-1 branch January 15, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - PWA manifest file does not load when behind Cloudflare Access, requires crossorigin="use-credentials"
2 participants