fix: recipe scaler throwing error on empty serving size #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
approved these changes
Oct 29, 2024
Kuchenpirat
deleted the
fix-scaler-throwing-error-on-empty-serving-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The scaler was trying to parse the recipe serving size to determine the numerator / denominator. This moves the check on wheter basic yield is null to before the rounding of the number so we never try to round a null value.
When executed on a null value errors were thrown to the console in production and i had 404 pages pop up for recipes with missing serving sizes in dev.
Which issue(s) this PR fixes:
None
Testing
Verrified issue was no longer present on recipes that were throwing errors manually.