Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add shortcuts for PWA #3255

Merged

Conversation

boc-the-git
Copy link
Collaborator

What type of PR is this?

  • feature

What this PR does / why we need it:

Add "shortcuts" to the PWA. Effectively this enables you to open the app on your phone and head to either Meal Planner or Shopping Lists, as opposed to always to the home page. I imagine people are familiar with this concept from other apps, with a long press on the icon.

Production PWA:
original

Dev/PR PWA:
dev

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

Icons unfortunately don't work with the Nuxt PWA functionality. Hell, even the shortcuts attribute is undocumented by Nuxt..
There is a years old open issue where people are asking about the icon support, nuxt-community/pwa-module#309

Testing

Manual, on my phone. Confirmed that adding an "icons" attribute to the shortcut breaks the PWA (you can see it in the original commit) so removed that :(

Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tried looking into how to make this translatable, but the closest thing I could find was this issue with no updates: nuxt-community/pwa-module#312. So I guess we're stuck with English-only support

@michael-genson michael-genson enabled auto-merge (squash) March 5, 2024 23:34
@michael-genson michael-genson merged commit 805e1c2 into mealie-recipes:mealie-next Mar 5, 2024
9 checks passed
@janssenvdh
Copy link

I am unable to get the PWA shortcuts to work on iOS. I reinstalled the PWA as instructed in the release notes for v1.3.0. I am using iOS 17.4.1 and I am running Mealie v1.7.0 in Docker.

@michael-genson
Copy link
Collaborator

I have an Android phone, however one issue I had was getting the newest version of the PWA after updating my docker image. Try uninstalling the PWA, clearing all of your Mealie-related site data on the browser that launches/installs your PWA, then re-installing the PWA

@janssenvdh
Copy link

Thanks for the reply. Clearing the browser history while the PWA was uninstalled did not enable the shortcuts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants