Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Add "shortcuts" to the PWA. Effectively this enables you to open the app on your phone and head to either Meal Planner or Shopping Lists, as opposed to always to the home page. I imagine people are familiar with this concept from other apps, with a long press on the icon.
Production PWA:
Dev/PR PWA:
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Icons unfortunately don't work with the Nuxt PWA functionality. Hell, even the
shortcuts
attribute is undocumented by Nuxt..There is a years old open issue where people are asking about the icon support, nuxt-community/pwa-module#309
Testing
Manual, on my phone. Confirmed that adding an "icons" attribute to the shortcut breaks the PWA (you can see it in the original commit) so removed that :(