-
-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: First Time Setup Wizard #3204
Merged
hay-kot
merged 25 commits into
mealie-recipes:mealie-next
from
michael-genson:feat/first-time-setup
Mar 11, 2024
Merged
feat: First Time Setup Wizard #3204
hay-kot
merged 25 commits into
mealie-recipes:mealie-next
from
michael-genson:feat/first-time-setup
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hay-kot
requested changes
Mar 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled down and tested, everything looks good to me besides my one comment about verifying the current password.
It's lost in the merge commit but I removed the backend password stuff (I just let the OIDC PR overwrite the changes since there was a conflict there anyway) |
michael-genson
force-pushed
the
feat/first-time-setup
branch
from
March 10, 2024 20:33
fc28c2f
to
de349a1
Compare
hay-kot
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This PR adds a first time setup wizard. It was first proposed in #1164, but getting this ready before V1 would've been too much. Now that we're past V1, we're in a good place to add this sort of thing.
When a user logs-in as the default user (
[email protected]
), or they go to the root URL while logged-in with the default user (index), they are redirected to/admin/setup
. Here they perform a few tasks:Once that's complete, they're given a list of places to check out (e.g. migrations).
Here's a full walkthrough of the new setup wizard:
I think there's more that can be done here to help new setups, but as-is I'm pretty happy with how it turned out, and adding-on to it should be pretty straight-forward.
Which issue(s) this PR fixes:
(REQUIRED)
N/A, idea comes from #1164
Fixes 2166
Special notes for your reviewer:
(fill-in or delete this section)
A few implementation notes:
Testing
(fill-in or delete this section)
Added a backend test for the update password change, and did end to end testing for new instances as well as registrations (since that draws from the same code)