Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dragable items in ingredient parser #3162

Conversation

Kuchenpirat
Copy link
Collaborator

@Kuchenpirat Kuchenpirat commented Feb 12, 2024

What type of PR is this?

  • feature

What this PR does / why we need it:

This PR adds the ability to drag the items in the ingredient parser. The RecipeIngredientEditor UI suggests that this is possible, but it is only implemented for normal Recipe Edit Page.

Which issue(s) this PR fixes:

fixes #3126

Special notes for your reviewer:

  • could not get animations to play nicely with it, so it's not as nice as in the ingredient editor. If anybody has an idea how to get this to work, a hint would be welcome.
  • This looks like way more than it actually is. I just added the draggable component and wrapped it around the expansion pannels.

Testing

Manual testing

@Kuchenpirat Kuchenpirat changed the title Feat dragable items in ingredient parser feat: dragable items in ingredient parser Feb 12, 2024
@boc-the-git boc-the-git merged commit e1a87b3 into mealie-recipes:mealie-next Feb 14, 2024
9 checks passed
@Kuchenpirat Kuchenpirat deleted the feat--dragable-items-in-ingredient-parser branch February 14, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Click-and-drag re-ordering ingredients doesn't work in "parse" screen
2 participants