refactor: Remove Passlib #3045
Merged
refactor: Remove Passlib #3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boc-the-git
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This removes passlib and just uses bcrypt directly.
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3040
Special notes for your reviewer:
(fill-in or delete this section)
Originally I intended to just suppress the faulty log discussed in #3040, but considering we barely use passlib anyway (and we only use it as a wrapper for bcrypt) I figured I'd just get rid of it.
Testing
(fill-in or delete this section)
Existing tests. I also verified that I can log-in with my own account (i.e. I confirmed existing passwords are compatible)