Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate with eslint-mdx to lint .mdx with ESLint, ready for reviewing #726

Merged
merged 3 commits into from
Aug 14, 2019
Merged

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Aug 11, 2019

eslint-mdx is a ESLint Parser/Plugin for MDX, helps you lint all ES syntaxes excluding code block of course. Work perfectly with eslint-plugin-import, eslint-plugin-prettier or any other eslint plugins.

It is a complete rewriting from scratch for eslint-plugin-mdx.

@vercel
Copy link

vercel bot commented Aug 11, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://mdx-git-fork-jounqin-patch-1.mdx.now.sh

@vercel vercel bot temporarily deployed to staging August 11, 2019 07:32 Inactive
@vercel vercel bot temporarily deployed to staging August 11, 2019 09:34 Inactive
@JounQin JounQin changed the title docs: Add eslint-mdx into document [Draft] docs: Add eslint-mdx into document Aug 11, 2019
@vercel vercel bot temporarily deployed to staging August 11, 2019 13:46 Inactive
@vercel vercel bot temporarily deployed to staging August 11, 2019 13:49 Inactive
@JounQin JounQin changed the title [Draft] docs: Add eslint-mdx into document feat: integrate with eslint-mdx to lint .mdx with ESLint, ready for reviewing Aug 11, 2019
@vercel vercel bot temporarily deployed to staging August 11, 2019 13:54 Inactive
@wooorm wooorm mentioned this pull request Aug 12, 2019
Copy link
Member

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing @JounQin! Do you mind fixing the conflict in yarn.lock and then I can merge?

ESLint Parser/Plugin for MDX, helps you lint all ES syntaxes excluding `code` block of course. Work perfectly with `eslint-plugin-import`, `eslint-plugin-prettier` or any other eslint plugins.

It is a complete rewriting from scratch for [eslint-plugin-mdx](https://github.com/azz/eslint-plugin-mdx).
@vercel vercel bot temporarily deployed to staging August 13, 2019 23:27 Inactive
@JounQin
Copy link
Member Author

JounQin commented Aug 13, 2019

@johno Done. THX for reviewing.

@johno
Copy link
Member

johno commented Aug 14, 2019

Thanks!

@johno johno merged commit bfe31e8 into mdx-js:master Aug 14, 2019
@JounQin JounQin deleted the patch-1 branch August 14, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants