Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tables) remove new line backtick wrapping #180

Merged
merged 1 commit into from
Jul 6, 2018
Merged

fix(tables) remove new line backtick wrapping #180

merged 1 commit into from
Jul 6, 2018

Conversation

ifyoumakeit
Copy link
Contributor

Removes warning...

Warning: validateDOMNesting(...): Whitespace text nodes cannot appear as a child of <thead>. Make sure you don't have any extra whitespace between tags on each line of your source code.
  • Remove wrap of new lines
  • Add table to fixture
  • Create test to fail on single wrapped new lines
  • Update test with wrapped line and extra 's'
  • Add table to next.js example

closes #151

fix(tables) remove new line backtick wrapping
2846151 
Removes extra whitespace between tags due to \n being wrapped.

- Add table to fixture
- Create test to fail on single wrapped new lines
- Update test with wrapped line and extra 's'
- Add table to next.js example

closes mdx-js#151
@ifyoumakeit
Copy link
Contributor Author

Thanks for the awesome work with these packages! Currently trying it out for documenting our React Design System and came across these warnings.

@johno
Copy link
Member

johno commented Jul 6, 2018

Thank you!

@johno johno merged commit 4c469fb into mdx-js:master Jul 6, 2018
@johno
Copy link
Member

johno commented Jul 6, 2018

Published as a prerelease, 0.13.1-1. Please let me know if you encounter any issues.

@ifyoumakeit ifyoumakeit deleted the new-line branch July 7, 2018 05:12
johno pushed a commit that referenced this pull request Jul 12, 2018
@ifyoumakeit @johno
fix(tables) remove new line backtick wrapping (#180)
5677ad5 
Removes extra whitespace between tags due to \n being wrapped.

- Add table to fixture
- Create test to fail on single wrapped new lines
- Update test with wrapped line and extra 's'
- Add table to next.js example

closes #151
johno pushed a commit that referenced this pull request Jul 23, 2018
@ifyoumakeit @johno
fix(tables) remove new line backtick wrapping (#180)
59f1983 
Removes extra whitespace between tags due to \n being wrapped.

- Add table to fixture
- Create test to fail on single wrapped new lines
- Update test with wrapped line and extra 's'
- Add table to next.js example

closes #151
@silvenon silvenon mentioned this pull request Aug 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning when rendering tables
2 participants
@ifyoumakeit @johno