-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax highlighting stops working when indented #209
Comments
Is there any progress with this? I think it's a pretty crucial thing to fix. :( |
I can also confirm the exact behavior as outlined above. Would love to know if there is a solution to this or if peeps are even properly aware of it. (: It doesn't even need opening and closing tags to be indented. As soon as the opening tag is not indented it starts failing to highlight the inner markdown. Doesn't seem to break everything though, as HTML is still working fine. |
This now pulls in a grammar for from: <https://github.com/wooorm/markdown-tm-language>. It fixes a bunch of previous errors and adds real support for MDX. It also supports YAML frontmatter, TOML frontmatter, GFM (autolink literals, footnotes, strikethrough, tables, tasklists), GitHub (gemoji, mentions, references). There’s support for about 20 common embedded grammars in fenced code blocks. Embedded code (in fenced code blocks, or in ESM/expressions) is now marked as being the correct language, which makes comments and such work. Closes GH-183. Closes GH-191. Closes GH-209. Closes GH-221.
Initial checklist
Affected packages and versions
VSCode MDX v0.3.2
Link to runnable example
No response
Steps to reproduce
Use the attached MDX file in archive in VSCode 1.69.2 with VSCode MDX v0.3.2.
vscode-mdx-indent-test.mdx.zip
Expected behavior
Syntax highlighting should preferably happen at all times, meaning:
If the markdown usage of tabs conflicts with this, then at least the wrappers should work.
Actual behavior
First of all, thanks for a cool extension!
It stops working for me however when it is indented and/or wrapped in another element.
Here's the MDX in question (I've attached the file above):
I use a lot of wrappers in my MDX files, so this sort of breaks the extension for me...
Runtime
No response
Package manager
No response
OS
macOS
Build and bundle tools
No response
The text was updated successfully, but these errors were encountered: