fix: correct handling of nested forms

mdx-editor · Oct 5, 2023 · a152e8a · a152e8a
1 parent 1ca4924
commit a152e8a
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/src/plugins/core/PropertyPopover.tsx b/src/plugins/core/PropertyPopover.tsx
@@ -45,7 +45,8 @@ export const PropertyPopover: React.FC<PropertyPopoverProps> = ({ title, propert
             onSubmit={(e) => {
               void handleSubmit(onChange)(e)
               setOpen(false)
-              e.nativeEvent.stopImmediatePropagation()
+              e.preventDefault()
+              e.stopPropagation()
             }}
           >
             <h3 className={styles.propertyPanelTitle}>{title} Attributes</h3>

diff --git a/src/plugins/frontmatter/FrontmatterEditor.tsx b/src/plugins/frontmatter/FrontmatterEditor.tsx
@@ -68,7 +68,7 @@ export const FrontmatterEditor = ({ yaml, onChange }: FrontmatterEditorProps) =>
             <form
               onSubmit={(e) => {
                 void handleSubmit(onSubmit)(e)
-                e.nativeEvent.stopImmediatePropagation()
+                e.stopPropagation()
               }}
               onReset={() => setFrontmatterDialogOpen(false)}
             >

diff --git a/src/plugins/image/ImageDialog.tsx b/src/plugins/image/ImageDialog.tsx
@@ -47,7 +47,8 @@ export const ImageDialog: React.FC = () => {
             onSubmit={(e) => {
               void handleSubmit(saveImage)(e)
               reset({ src: '', title: '', altText: '' })
-              e.nativeEvent.stopImmediatePropagation()
+              e.preventDefault()
+              e.stopPropagation()
             }}
             className={styles.multiFieldForm}
           >

diff --git a/src/plugins/link-dialog/LinkDialog.tsx b/src/plugins/link-dialog/LinkDialog.tsx
@@ -51,7 +51,8 @@ export function LinkEditForm({ url, title, onSubmit, onCancel, linkAutocompleteS
     <form
       onSubmit={(e) => {
         void handleSubmit(onSubmit)(e)
-        e.nativeEvent.stopImmediatePropagation()
+        e.stopPropagation()
+        e.preventDefault()
       }}
       onReset={onCancel}
       className={classNames(styles.multiFieldForm, styles.linkDialogEditForm)}

diff --git a/src/plugins/toolbar/primitives/DialogButton.tsx b/src/plugins/toolbar/primitives/DialogButton.tsx
@@ -147,7 +147,7 @@ const DialogForm: React.FC<{
 
   const onSubmitEH = (e: React.FormEvent) => {
     e.preventDefault()
-    e.nativeEvent.stopImmediatePropagation()
+    e.stopPropagation()
     onSubmitCallback((inputProps as { value: string }).value)
   }