Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for ruby < 2.3.0 and update dev dependencies #16

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

jfeltesse-mdsol
Copy link
Contributor

Ruby 2.2 has reached EOL. Technically this gem is obviously still compatible with earlier versions so it's only about whether we want to support EOL rubies and the version the users of this gem are using.
AFAIK at medidata all ruby projects that are maintained and developed are at least at 2.3.x.

At the same time I cleaned up the dev dependencies:

  • updated where applicable
  • removed kender because it was not used
  • removed uuidtools because securerandom does the job just fine now

I also cleaned up the travis file, the fixes around bundler are not needed anymore.

About the semver, doing a major vs minor bump in this case is subject to interpretation.
I think this discussion on nokogiri's repo brings some good points in favor of not bumping major.

@mdsol/team-10 @ejennings-mdsol @johngluckmdsol

Copy link
Contributor

@ssteeg-mdsol ssteeg-mdsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link

@piao-mdsol piao-mdsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! And thanks for linking to the Nokogiri issue, bumping the version sounds reasonable to me too ✌️

@ssteeg-mdsol ssteeg-mdsol merged commit e30501e into master Sep 14, 2018
@ssteeg-mdsol ssteeg-mdsol deleted the feature/bump_ruby branch September 14, 2018 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants