Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Intel config file to work with HPE MPI #27

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Aug 23, 2023

Purpose

I updated the Intel config file so that it works with Intel MPI and HPE MPI (used on NAS). The config file checks for the I_MPI_ROOT environment variable to determine if Intel MPI is being used.

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I tested on one of our Intel MPI images and on NAS with HPE MPI.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner August 23, 2023 16:11
@sseraj sseraj requested review from eirikurj and yqliaohk August 23, 2023 16:11
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #27 (6910ab3) into main (fd7ac69) will not change coverage.
The diff coverage is n/a.

❗ Current head 6910ab3 differs from pull request most recent head 614c75e. Consider uploading reports for the commit 614c75e to get more accurate results

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   50.11%   50.11%           
=======================================
  Files           5        5           
  Lines        1688     1688           
=======================================
  Hits          846      846           
  Misses        842      842           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sseraj
Copy link
Collaborator Author

sseraj commented Sep 8, 2023

Reminder to review this. It should be quick

@yqliaohk yqliaohk merged commit ef16481 into main Sep 8, 2023
@sseraj sseraj deleted the intel-config branch September 8, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants