Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapenade check #10

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Tapenade check #10

merged 2 commits into from
Mar 1, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Mar 1, 2022

Purpose

I enabled the Tapenade check on Azure. The check ensures that the differentiated code is kept up to date with the source.

Expected time until merged

By the end of the week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner March 1, 2022 14:58
@sseraj sseraj requested review from eirikurj and yqliaohk March 1, 2022 14:58
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #10 (bfc95f4) into master (e79b8ac) will not change coverage.
The diff coverage is n/a.

❗ Current head bfc95f4 differs from pull request most recent head 19ee079. Consider uploading reports for the commit 19ee079 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   46.97%   46.97%           
=======================================
  Files           5        5           
  Lines        1816     1816           
=======================================
  Hits          853      853           
  Misses        963      963           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79b8ac...19ee079. Read the comment docs.

@sseraj
Copy link
Collaborator Author

sseraj commented Mar 1, 2022

flake8 is failing because it is not ignoring files that it should be. I'm not sure what's going on. Any ideas @nwu63?

@sseraj
Copy link
Collaborator Author

sseraj commented Mar 1, 2022

flake8 is now passing again. Thanks @nwu63

The Tapenade check is also working so this should be good to go.

@yqliaohk yqliaohk merged commit ff87dff into master Mar 1, 2022
@sseraj sseraj deleted the tapenade-check branch March 1, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants