-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage #48
Add coverage #48
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=========================================
Coverage ? 76.37%
=========================================
Files ? 3
Lines ? 364
Branches ? 0
=========================================
Hits ? 278
Misses ? 86
Partials ? 0 Continue to review full report at Codecov.
|
Okay I think the coverage is 0 because we are running |
I just tried running a basic test locally and can confirm that the issue is with |
Yeah I think a separate PR makes sense, then we just merge |
Is this ready for review or are we waiting for #54? |
.github/build_real.sh
Outdated
@@ -2,4 +2,4 @@ | |||
set -e | |||
cp $CONFIG_FILE config/config.mk | |||
make | |||
pip install . | |||
pip install -e . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer needed
Purpose
Added codecov coverage
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR