Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self.comm is now set in BaseSolver #37

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Jan 7, 2021

Purpose

With recent addition of self.comm to BaseSolver in baseclasses (see mdolab/baseclasses#29) self.comm will is overwritten.
However, PR mdolab/baseclasses#30 now adds self.comm as an argument to BaseSolver making it clear to the user where self.comm is set and less error-prone.
This PR adjusts the code to the above changes.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner January 7, 2021 11:46
@eirikurj eirikurj requested review from SichengHe and sseraj January 7, 2021 11:46
ewu63
ewu63 previously approved these changes Jan 7, 2021
pyhyp/pyHyp.py Outdated Show resolved Hide resolved
sseraj
sseraj previously approved these changes Jan 7, 2021
ewu63
ewu63 previously approved these changes Jan 7, 2021
@eirikurj eirikurj dismissed stale reviews from ewu63 and sseraj via b6ce525 January 7, 2021 22:34
@ewu63 ewu63 merged commit 81c96bf into mdolab:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants