-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented multi-section surface parameterization #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g root. Started proper multi-section surface implementation.
… mesh bug fix to function properly with symmetry.
Ready for review |
kanekosh
requested changes
Nov 20, 2024
Ready for review |
kanekosh
previously approved these changes
Nov 21, 2024
kanekosh
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In support of the Army/CDI project I have implemented a multi-section geometry group for OpenAeroStruct that allows the optimizer to have full control over individual wing sections using all existing OpenAeroStruct transformations. Two approaches for facilitating C0 continuity between sections, by constraint or by construction, are provided. In addition, an automatic mesh generator for multi-section wing is implemented. This feature can be back-ported to single-section surfaces in a future PR.
Expected time until merged
3 weeks
Type of change
Testing
Tests for multi-section geometries have been added.
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable