Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented multi-section surface parameterization #446

Merged
merged 76 commits into from
Nov 21, 2024

Conversation

sabakhshi
Copy link
Contributor

@sabakhshi sabakhshi commented Sep 23, 2024

Purpose

In support of the Army/CDI project I have implemented a multi-section geometry group for OpenAeroStruct that allows the optimizer to have full control over individual wing sections using all existing OpenAeroStruct transformations. Two approaches for facilitating C0 continuity between sections, by constraint or by construction, are provided. In addition, an automatic mesh generator for multi-section wing is implemented. This feature can be back-ported to single-section surfaces in a future PR.

Expected time until merged

3 weeks

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Tests for multi-section geometries have been added.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

…g root. Started proper multi-section surface implementation.
… mesh bug fix to function properly with symmetry.
@sabakhshi
Copy link
Contributor Author

Ready for review

@sabakhshi sabakhshi requested a review from kanekosh November 19, 2024 22:27
openaerostruct/utils/testing.py Outdated Show resolved Hide resolved
tests/integration_tests/test_multi_2_sec.py Show resolved Hide resolved
tests/integration_tests/test_multi_2_sec.py Outdated Show resolved Hide resolved
@sabakhshi
Copy link
Contributor Author

Ready for review

@sabakhshi sabakhshi requested a review from kanekosh November 20, 2024 23:43
kanekosh
kanekosh previously approved these changes Nov 21, 2024
@kanekosh kanekosh merged commit 4332e6e into mdolab:main Nov 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants