-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a failure criteria for using Composite Materials (Tsai Wu Failure Criteria) #444
Open
vishhwamehta
wants to merge
39
commits into
mdolab:main
Choose a base branch
from
vishhwamehta:tsaiwu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
5eb646f
initial commit for tsaiwu wingbox package
vishhwamehta fe4c98d
Merge remote-tracking branch 'origin/main' into tsaiwu
A-CGray 172358b
Merge remote-tracking branch 'vishwaoas/main' into tsaiwu
vishhwamehta a93d002
Make geometry spline interpolation mesh independent
A-CGray f24412f
formatting changes
vishhwamehta b1dfd08
Merge branch 'main' into tsaiwu
vishhwamehta fb7f79f
Merge branch 'tsaiwu' of github.com:vishhh17/OpenAeroStruct into tsaiwu
A-CGray d981854
implemented "useComposite" in the surfdict for the option of using co…
vishhwamehta 92074f7
changed the surface dictionary in the test files to work with the new…
vishhwamehta 720216b
Merge branch 'tsaiwu' of github.com:vishhh17/OpenAeroStruct into tsaiwu
A-CGray c2b25e7
Made the changes with if statements of "useComposite", bug fixes with…
vishhwamehta 09de0aa
cleaning all the codes, removing unnecessary comments and updating th…
vishhwamehta 052ecdb
bug fixes due to the hardcoded 4 plies
vishhwamehta 64c5b8a
Merge branch 'tsaiwu' of github.com:vishhh17/OpenAeroStruct into tsaiwu
A-CGray adff022
Modify surface dictionary checks
A-CGray 319a172
Rename surface dict variables to follow OAS conventions
A-CGray 8ce1867
Undo artifact from previous merge
A-CGray 40ca8db
Fix error message
A-CGray af4c36f
correcting the spatial_beam_functionals
vishhwamehta a415013
`black -l 120 .`
A-CGray f386a44
`black -l 120 .`
A-CGray f7710bb
Fix docstring in failure_ks
A-CGray 8977de6
fixing the files flagged for pull request tests
vishhwamehta 88f47a5
Merge branch 'tsaiwu' of github.com:vishhh17/OpenAeroStruct into tsaiwu
vishhwamehta 96c0cd0
removing the call for shwoing n2, and fixing formatting bug
vishhwamehta 2c53537
removing the asert.near.equal import statement from test file
vishhwamehta 9c52af8
failure files and check_surface_dict modified to use "safety_factor".…
vishhwamehta c2f5734
removed unused import statements, adding option for the cases where s…
vishhwamehta 2e33dd5
creating and editing the documentation files for OAS documentation
vishhwamehta a22061b
updating heirarchy for the documentation files
vishhwamehta 454b0a1
Add code excerpt to composites doc page
A-CGray 906f585
documemtation for composite wingbox
vishhwamehta 0205b35
updated the documentation page
vishhwamehta e98d007
changed the safety factor documentation and added the Pareto front to…
vishhwamehta 1620271
Simplifying some code in failure_ks
A-CGray 78107d4
small docs fix
A-CGray cfd8706
variable renaming
A-CGray bd1aa92
More robust if check
A-CGray 2e6e9c0
Check against lower case strings
A-CGray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
""" | ||
Class definition for the MeshPointForces component. | ||
""" | ||
|
||
import numpy as np | ||
import openmdao.api as om | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not critical, but I'd use lower case and underscores for function names. Same for the computeCompositeStiffness function
https://peps.python.org/pep-0008/#function-and-variable-names