-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating MPhys wrapper for 2.0 update #428
Conversation
It looks like the CI tests are failing due to the fact that MPhys 1.1.0 is pinned in the Azure pipeline. Is there a way to update this when MPhys 2.0 is released @A-CGray? |
Ah yeah, this is kind of a pain, we probably won't update the docker images that the CI jobs use to MPhys 2 until our other codes like ADflow and pyGeo are MPhys 2 compatible. In the meantime, I've added a line to the script that install OpenAeroStruct in the CI jobs that removes the pip constraint on the mphys version so that it can install mphys 2 itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Tim!
I believe integration_tests/test_simple_rect_mphys_aero.py
and test_simple_rect_mphys_aero_compressible.py
also need to be updated. These tests are currently skipped (rather than tests being failed) as a result of failed Mphys import.
Good catch @kanekosh, should be fixed now |
Purpose
Refactored builder class to use new mphys import procedures and variable naming convention. MPhys 2.0 has officially been released, so this PR is ready to be merged in. This is a backwards-incompatible change for the MPhys wrapper, so I'd recommend making a version bump after this PR.
Expected time until merged
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable