Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating MPhys wrapper for 2.0 update #428

Merged
merged 14 commits into from
Dec 16, 2024
Merged

Conversation

timryanb
Copy link
Contributor

@timryanb timryanb commented May 17, 2024

Purpose

Refactored builder class to use new mphys import procedures and variable naming convention. MPhys 2.0 has officially been released, so this PR is ready to be merged in. This is a backwards-incompatible change for the MPhys wrapper, so I'd recommend making a version bump after this PR.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@timryanb
Copy link
Contributor Author

It looks like the CI tests are failing due to the fact that MPhys 1.1.0 is pinned in the Azure pipeline. Is there a way to update this when MPhys 2.0 is released @A-CGray?

@timryanb timryanb marked this pull request as ready for review December 13, 2024 14:05
@timryanb timryanb requested a review from a team as a code owner December 13, 2024 14:05
@timryanb timryanb requested review from lamkina and kanekosh December 13, 2024 14:05
@A-CGray
Copy link
Member

A-CGray commented Dec 13, 2024

It looks like the CI tests are failing due to the fact that MPhys 1.1.0 is pinned in the Azure pipeline. Is there a way to update this when MPhys 2.0 is released @A-CGray?

Ah yeah, this is kind of a pain, we probably won't update the docker images that the CI jobs use to MPhys 2 until our other codes like ADflow and pyGeo are MPhys 2 compatible. In the meantime, I've added a line to the script that install OpenAeroStruct in the CI jobs that removes the pip constraint on the mphys version so that it can install mphys 2 itself.

Copy link
Contributor

@kanekosh kanekosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Tim!
I believe integration_tests/test_simple_rect_mphys_aero.py and test_simple_rect_mphys_aero_compressible.py also need to be updated. These tests are currently skipped (rather than tests being failed) as a result of failed Mphys import.

@timryanb
Copy link
Contributor Author

Thank you, Tim! I believe integration_tests/test_simple_rect_mphys_aero.py and test_simple_rect_mphys_aero_compressible.py also need to be updated. These tests are currently skipped (rather than tests being failed) as a result of failed Mphys import.

Good catch @kanekosh, should be fixed now

@timryanb timryanb requested a review from kanekosh December 16, 2024 15:18
@kanekosh kanekosh merged commit 2802be2 into mdolab:main Dec 16, 2024
9 checks passed
@timryanb timryanb deleted the mphys-2.0 branch December 16, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants