-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MPhys Interface #401
Conversation
# Conflicts: # .github/workflows/oas.yml
Codecov Report
@@ Coverage Diff @@
## main #401 +/- ##
==========================================
- Coverage 96.62% 94.47% -2.15%
==========================================
Files 93 103 +10
Lines 6012 6412 +400
==========================================
+ Hits 5809 6058 +249
- Misses 203 354 +151
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My non-MPhys comments, Andrew has MPhys comments in progress
@@ -27,7 +27,8 @@ jobs: | |||
PYTHON_VERSION_LATEST: ['3.11'] | |||
NUMPY_VERSION_OLDEST: ['1.20'] # latest is most recent on PyPI | |||
SCIPY_VERSION_OLDEST: ['1.6.0'] # latest is most recent on PyPI | |||
OPENMDAO_VERSION_OLDEST: ['3.10'] # latest is most recent on PyPI | |||
OPENMDAO_VERSION_OLDEST: ['3.15'] # latest is most recent on PyPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary for MPhys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the minimum supported version for Mphys 1.0.0 is 3.15. This is due to a bug that was present in older version of OpenMDAO involving distributed derivatives
Purpose
Expected time until merged
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable