Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MPhys Interface #401

Merged
merged 59 commits into from
Mar 31, 2023
Merged

Adding MPhys Interface #401

merged 59 commits into from
Mar 31, 2023

Conversation

timryanb
Copy link
Contributor

Purpose

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@timryanb timryanb requested a review from eytanadler March 17, 2023 17:40
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #401 (4dcddbe) into main (de09342) will decrease coverage by 2.15%.
The diff coverage is 69.12%.

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   96.62%   94.47%   -2.15%     
==========================================
  Files          93      103      +10     
  Lines        6012     6412     +400     
==========================================
+ Hits         5809     6058     +249     
- Misses        203      354     +151     
Impacted Files Coverage Δ
openaerostruct/aerodynamics/mtx_rhs.py 100.00% <ø> (ø)
...enaerostruct/functionals/total_aero_performance.py 100.00% <ø> (ø)
openaerostruct/functionals/total_performance.py 100.00% <ø> (ø)
openaerostruct/mphys/surface_contours.py 9.52% <9.52%> (ø)
openaerostruct/mphys/lift_distribution.py 11.76% <11.76%> (ø)
openaerostruct/mphys/aero_builder.py 86.88% <86.88%> (ø)
openaerostruct/mphys/aero_funcs_group.py 90.47% <90.47%> (ø)
openaerostruct/geometry/utils.py 61.78% <92.30%> (+0.91%) ⬆️
openaerostruct/mphys/aero_mesh.py 94.11% <94.11%> (ø)
openaerostruct/aerodynamics/coeffs.py 100.00% <100.00%> (ø)
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@eytanadler eytanadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My non-MPhys comments, Andrew has MPhys comments in progress

@@ -27,7 +27,8 @@ jobs:
PYTHON_VERSION_LATEST: ['3.11']
NUMPY_VERSION_OLDEST: ['1.20'] # latest is most recent on PyPI
SCIPY_VERSION_OLDEST: ['1.6.0'] # latest is most recent on PyPI
OPENMDAO_VERSION_OLDEST: ['3.10'] # latest is most recent on PyPI
OPENMDAO_VERSION_OLDEST: ['3.15'] # latest is most recent on PyPI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary for MPhys?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the minimum supported version for Mphys 1.0.0 is 3.15. This is due to a bug that was present in older version of OpenMDAO involving distributed derivatives

setup.py Show resolved Hide resolved
README.md Show resolved Hide resolved
openaerostruct/mphys/aero_builder.py Outdated Show resolved Hide resolved
@timryanb timryanb requested review from lamkina and eytanadler and removed request for lamkina and eytanadler March 24, 2023 15:46
@eytanadler eytanadler mentioned this pull request Mar 30, 2023
13 tasks
@eytanadler eytanadler requested a review from lamkina March 30, 2023 23:13
@lamkina lamkina merged commit d1bff2d into mdolab:main Mar 31, 2023
@timryanb timryanb deleted the mphys branch March 31, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants