Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aerostruct_groups.py #392

Merged
merged 4 commits into from
Jun 25, 2022
Merged

Update aerostruct_groups.py #392

merged 4 commits into from
Jun 25, 2022

Conversation

acmarta
Copy link
Contributor

@acmarta acmarta commented Jun 23, 2022

Promote section lift coefficient distribution, Cl, in surfaces

Purpose

Type of change

  • Other (please describe)

Promote section lift coefficient
@acmarta acmarta requested a review from a team as a code owner June 23, 2022 14:03
@acmarta acmarta requested review from kanekosh and eytanadler June 23, 2022 14:03
@eytanadler
Copy link
Collaborator

eytanadler commented Jun 23, 2022

While the tests are running, I have a couple comments:

  1. What do we think about also adding "CDw" to the promotes while we're at it @kanekosh?
  2. Could you please bump the version in openaerostruct/__init__.py to "2.5.1"

@kanekosh
Copy link
Contributor

What do we think about also adding "CDw" to the promotes

That's a good point, could you add that too @acmarta ?

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #392 (86bc9e4) into main (e79bada) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files          93       93           
  Lines        6009     6009           
=======================================
  Hits         5807     5807           
  Misses        202      202           
Impacted Files Coverage Δ
openaerostruct/integration/aerostruct_groups.py 97.48% <ø> (ø)
openaerostruct/__init__.py 100.00% <100.00%> (ø)
openaerostruct/aerodynamics/pg_scale.py 100.00% <100.00%> (ø)
openaerostruct/aerodynamics/pg_wind_rotation.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@acmarta
Copy link
Contributor Author

acmarta commented Jun 24, 2022

Added "CDw" to the list of promotes

@eytanadler
Copy link
Collaborator

Added "CDw" to the list of promotes

Thanks!

  1. Could you please bump the version in openaerostruct/__init__.py to "2.5.1"

And this one too @acmarta

@acmarta
Copy link
Contributor Author

acmarta commented Jun 25, 2022

Version bumped to 2.5.1

@eytanadler
Copy link
Collaborator

Version bumped to 2.5.1

Sorry maybe I should've been more clear, it's fine just to do it in this PR. I'll take care of it and then we can get this merged. Thanks for the contribution!

@eytanadler eytanadler mentioned this pull request Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants