DEV: Set owner on widget instances (discourse#22391)

This allows us to use `getOwner(this)` on widgets (without needing to resort to our custom `discourse-common/lib/get-owner` implementation which has a hacky fallback)
mdoggydog · Jul 3, 2023 · 1b693d0 · 1b693d0
1 parent 0790e9f
commit 1b693d0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/app/assets/javascripts/discourse-common/addon/lib/get-owner.js b/app/assets/javascripts/discourse-common/addon/lib/get-owner.js
@@ -42,5 +42,7 @@ export function getRegister(obj) {
     },
   };
 
+  setOwner(register, owner);
+
   return register;
 }
diff --git a/app/assets/javascripts/discourse/app/widgets/widget.js b/app/assets/javascripts/discourse/app/widgets/widget.js
@@ -24,6 +24,7 @@ import { get } from "@ember/object";
 import { h } from "virtual-dom";
 import { isProduction } from "discourse-common/config/environment";
 import { consolePrefix } from "discourse/lib/source-identifier";
+import { getOwner, setOwner } from "@ember/application";
 
 const _registry = {};
 
@@ -146,6 +147,7 @@ export default class Widget {
     this.dirtyKeys = opts.dirtyKeys;
 
     register.deprecateContainer(this);
+    setOwner(this, getOwner(register));
 
     this.key = this.buildKey ? this.buildKey(attrs) : null;
     this.site = register.lookup("service:site");
-Original file line number
+Diff line change
@@ Expand Up / @@ -42,5 +42,7 @@ export function getRegister(obj) { @@
         },
       };
+      setOwner(register, owner);
       return register;
     }