fix(docs): restore behavior of description term links #9811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OnkarRuikar Would you be interested in reviewing this PR? |
OnkarRuikar
reviewed
Oct 13, 2023
|
This how the suggestion works: definitionTermLinks.mp4 |
Co-authored-by: Onkar Ruikar <[email protected]>
Co-authored-by: Onkar Ruikar <[email protected]>
|
@OnkarRuikar Thank you for catching those issues! 🙌 |
caugner
changed the title
OnkarRuikar
suggested changes
Oct 13, 2023
Co-authored-by: Onkar Ruikar <[email protected]>
caugner
force-pushed
the
fix-dt-page-link-color
branch
from
1a3939f to
fe2be51
Compare
OnkarRuikar
approved these changes
Oct 13, 2023
|
Thank you for the thorough reviews @OnkarRuikar! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9810.
Problem
#8413 introduced a regression, making it unable to identify description terms (
<dt>) that link to another page.Solution
Restore the style of those links, excluding anchor links.
Also makes the hashtag of the anchor links interactive.
Screenshots
Before
After
How did you test this change?
Ran
yarn devand opened http://localhost:3000/en-US/docs/Web/CSS/border#values locally.