-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(macros/LearnSidebar): add "HTML forms in legacy browsers" #9202
Conversation
Added HTML forms in legacy browsers link in Advanced forms articles
Added HTML forms in legacy browsers link in Advanced forms articles Signed-off-by: Kashyap Kaki <[email protected]>
…dn#9194) Signed-off-by: Kashyap Kaki <[email protected]>
Signed-off-by: Kashyap Kaki <[email protected]>
Signed-off-by: Kashyap Kaki <[email protected]>
Signed-off-by: Kashyap Kaki <[email protected]>
Signed-off-by: Kashyap Kaki <[email protected]>
…dn#9195) Signed-off-by: Kashyap Kaki <[email protected]>
Signed-off-by: Kashyap Kaki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I defer to @wbamberg about whether this is the right position in the sidebar.
@kashyapkaki Oh, it looks like some of your commits aren't signed. Can you please have a look at this failing check and follow the instructions? 🙏 |
Thanks for tagging. Yes, I've signed and pushed the commit again. Thank you. |
@caugner Is that still showing I haven't signed the commits? |
Unfortunately, yes. 🤔 Could you please try to follow these steps:
This should put the branch in a state where it has a single verified commit. |
Summary
Fixes #9349
Problem
Learn/Forms/HTML_forms_in_legacy_browsers page is missing from the MDN Web Forms sidebar.
Solution
Added "HTML form in legacy browsers" under the "Advanced forms articles" sidebar subsection.
Screenshot
How did you test this change?
Verified by running the code locally.