Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): add "HTML forms in legacy browsers" #9202

Merged
merged 11 commits into from
Sep 26, 2023

Conversation

kashyapkaki
Copy link
Contributor

Summary

Fixes #9349

Problem

Learn/Forms/HTML_forms_in_legacy_browsers page is missing from the MDN Web Forms sidebar.

Solution

Added "HTML form in legacy browsers" under the "Advanced forms articles" sidebar subsection.

Screenshot

image


How did you test this change?

Verified by running the code locally.

kashyapkaki and others added 2 commits June 28, 2023 23:59
Added HTML forms in legacy browsers link in Advanced forms articles
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Jun 29, 2023
@caugner caugner changed the title Added MDN Web Forms sidebar link chore(macros/LearnSidebar): add "HTML forms in legacy browsers" Jul 5, 2023
@caugner caugner requested a review from wbamberg July 5, 2023 21:18
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I defer to @wbamberg about whether this is the right position in the sidebar.

@caugner
Copy link
Contributor

caugner commented Jul 6, 2023

@kashyapkaki Oh, it looks like some of your commits aren't signed. Can you please have a look at this failing check and follow the instructions? 🙏

@kashyapkaki
Copy link
Contributor Author

@kashyapkaki Oh, it looks like some of your commits aren't signed. Can you please have a look at this failing check and follow the instructions? 🙏

Thanks for tagging. Yes, I've signed and pushed the commit again. Thank you.

@kashyapkaki
Copy link
Contributor Author

@kashyapkaki Oh, it looks like some of your commits aren't signed. Can you please have a look at this failing check and follow the instructions? 🙏

Thanks for tagging. Yes, I've signed and pushed the commit again. Thank you.

@caugner Is that still showing I haven't signed the commits?

@caugner
Copy link
Contributor

caugner commented Jul 10, 2023

Is that still showing I haven't signed the commits?

Unfortunately, yes. 🤔 Could you please try to follow these steps:

  1. Make sure to not have any uncommitted changes; in doubt run git stash to be safe.
  2. Run git checkout main and then git reset --hard 135c236 and finally git push --force

This should put the branch in a state where it has a single verified commit.

@caugner caugner marked this pull request as draft July 17, 2023 13:53
@caugner caugner marked this pull request as ready for review September 26, 2023 10:27
@caugner caugner merged commit 89f4b29 into mdn:main Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros sidebar content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Learn/Forms] Missing Sidebar Link
2 participants