fix(icons): use rotated thumbs-up as thumbs-down #9107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thumbs-down icon was more prominent than the thumbs-up icon.
LeoMcA
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Ha, I was a little confused how this worked at first, but it does work, so approved, however:
Alternatively, it might be better to use SVG's transform attribute to rotate?
Or, we could save the most marginal bit of bandwidth by removing the thumbs-down.svg and just setting the icon-thumbs-down class in icon scss file to use the thumbs-up.svg and the rotate css.
|
FWIW, the original orientation of thumb-down can be achived by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-481)
Problem
The
thumbs-upandthumbs-downicons are not the same, but thethumbs-downbutton is slightly bigger and so more prominent, skewing our results.Solution
Replace the
thumbs-down.svgby reusingthumbs-up.svgand addingstyle="transform: rotate(180deg);".Screenshots
Before
After
How did you test this change?
Opened http://localhost:3000/en-US/docs/Learn/HTML and verified that the icon has the same size.