Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blog): add feed icon to footer #9060

Merged
merged 1 commit into from
Jun 9, 2023
Merged

feat(blog): add feed icon to footer #9060

merged 1 commit into from
Jun 9, 2023

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Jun 9, 2023

Summary

https://mozilla-hub.atlassian.net/browse/MP-468

Problem

  • there is no clickable link to our feed (just the <link> in the header)

Solution

  • add a clickable link to our feed in the site footer

Screenshots

Before

image

After

image

How did you test this change?

  • yarn dev
  • yarn build:blog
  • visited localhost:5042
  • scrolled to footer
  • clicked the link

@LeoMcA LeoMcA requested a review from caugner June 9, 2023 16:35
caugner
caugner approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For me it's rather a feat(blog): add feed icon to footer though. 😛

@LeoMcA LeoMcA changed the title feat(footer): add blog feed icon feat(blog): add feed icon to footer Jun 9, 2023
@LeoMcA LeoMcA merged commit 0f6a075 into main Jun 9, 2023
@LeoMcA LeoMcA deleted the MP-468-rss-feed-icon branch June 9, 2023 17:14
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
Merged
@LeoMcA
Copy link
Member Author

LeoMcA commented Jun 9, 2023

Oops my squashed commit didn't pick up the updated PR title 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoMcA @caugner