Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(constants): add pl to RETIRED_LOCALES #8970

Merged
merged 1 commit into from
May 30, 2023
Merged

fix(constants): add pl to RETIRED_LOCALES #8970

merged 1 commit into from
May 30, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 30, 2023

Summary

Problem

https://developer.mozilla.org/pl returns a 404 instead of redirecting to en-US, because it is missing in the RETIRED_LOCALES list.

Solution

Add pl to the list.

How did you test this change?

Ran npm run copy-internal && npm start in /cloud-function and verified with curl https://localhost/pl:

% curl https://localhost/pl
Found. Redirecting to /en-US/?retiredLocale=pl

@caugner caugner requested a review from LeoMcA May 30, 2023 11:13
LeoMcA
LeoMcA approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caugner caugner merged commit 08c15a3 into main May 30, 2023
@caugner caugner deleted the add-pl-to-retired-locales branch May 30, 2023 13:08
@github-actions github-actions bot mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoMcA LeoMcA LeoMcA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caugner @LeoMcA