feat(cloud-function): implement Cloud Function + deploy to stage/prod #8366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
github-actions
bot
added
the
dependencies
This replaces `:` in the URL, for instance.
| proxyTelemetry | ||
| ); | ||
| router.all("/pong/*", requireOrigin(Origin.main), express.json(), proxyKevel); | ||
| router.all("/pimg/*", requireOrigin(Origin.main), proxyKevel); |
Check failure
Code scanning / CodeQL
Missing rate limiting
This was not the reason `/submit/mdn-yari` was broken.
| newLocation += `?${querystring}`; | ||
| } | ||
|
|
||
| res.set("Cache-Control", cacheControlValue).redirect(status, newLocation); |
Check warning
Code scanning / CodeQL
Server-side URL redirect
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to MP-277 and MP-278.
Problem
We're migrating to GCP.
In AWS, we have been using CloudFront behaviors and Lambdas to route requests to our API and S3 and set cache policies, but GCP has no equivalent services.
Solution
Implement a Cloud Function that routes requests to our API and Cloud Storage, setting
Cache-Controlheaders where applicable.How did you test this change?
Initially, we deployed the Cloud Function to a new
xyzenvironment at https://developer.allizom.xyz, and now it is also deployed to thestageenvironment at https://developer.allizom.org/.