Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): add webpack middlewares + don't proxy hot-update.json #5664

Merged
merged 3 commits into from
Mar 18, 2022
Merged

fix(server): add webpack middlewares + don't proxy hot-update.json #5664

merged 3 commits into from
Mar 18, 2022

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 17, 2022 •
edited
Loading

@caugner caugner added the 🐛 bug Something isn't working, or isn't working as expected label Mar 17, 2022
@caugner caugner requested review from fiji-flo and Guyzeroth March 17, 2022 23:03
@caugner caugner changed the title fix(server): setup hot reload properly fix(server): add webpack middlewares + don't proxy hot-update.json Mar 17, 2022
@caugner caugner force-pushed the fix-hot-reload branch 2 times, most recently from d87aca5 to 1806f41 Compare March 17, 2022 23:41
Guyzeroth
Guyzeroth approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@Guyzeroth Guyzeroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fix.

fiji-flo
fiji-flo approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

@caugner caugner merged commit 6b660c2 into mdn:main Mar 18, 2022
@caugner caugner deleted the fix-hot-reload branch March 18, 2022 10:42
@caugner caugner mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

@Guyzeroth Guyzeroth Guyzeroth approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working, or isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hot Reload with Webpack DevServer is broken
3 participants
@caugner @fiji-flo @Guyzeroth