enhance(ad-free): hide top-banner completely #11412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiji-flo
reviewed
Jul 3, 2024
caugner
commented
Jul 3, 2024
That shouldn't have been there.
fiji-flo
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
For me the advantage is that we don't need the change in user-context and have this bit of information only once in the system. Not having it taking effect instant avoids the layout shift (I'd rather then have the banner blank in that case).
Less changes, less code, sameish user experience.
But if you strongly feel about this I'll approve.
Just please first get it out on stage.
caugner
commented
Jul 4, 2024
caugner
changed the title
ferdnyc
pushed a commit
to ferdnyc/yari
that referenced
this pull request
Jul 13, 2024
When paying MDN Plus subscribers enable the "Ad-free experience", we now hide the top banner completely, rather than showing it with a fallback message. The top banner is hidden immediately, avoiding a layout shift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-1059)
Problem
We’re showing the “Get real-time assistance with your coding queries. Try AI Help now!” top-banner fallback, even if paying subscribers have enabled the Ad-Free Experience.
Solution
Hide the top-banner fallback if the Ad-Free Experience is enabled.
Screenshots
Before
After
How did you test this change?
Ran
yarn devlocally with local Rumba and changed the "Ad-free Experience" setting.