-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(macros/GamesSidebar): update WebVR -> WebXR link #10111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly referenced page does not seem to exist: https://developer.mozilla.org/en-US/docs/Games/Techniques/3D_on_the_web/WebXR
(Also note that WebVR_guide
is a key of the localStringMap
, and WebXR_guide
isn't.)
Right! I mentioned in the description that this PR must be merged after this content PR: I'll un-draft this after that's merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a +1 as the downstream is approved, thank you! 👍🏻
@zfox23 Unfortunately, the menu item no longer shows up: Note that you reference the
|
My apologies; I didn't understand your earlier comment but now I do. Will fix. |
Follow-up to fix a sidebar bug I introduced in #10111
Summary
The associated Content PR updates some documentation to refer to WebXR rather than WebVR. This updates a sidebar link to match the new URL.
Motivation
Additional details
This work came out of a comment on @bsmth's mdn/content#30696.
Related issues and pull requests
Must be merged after mdn/content#30721