Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macros/cssxref): use en-US page to fetch front matter key #8884

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

yarusome
Copy link
Contributor

Summary

Fixes #8883.

Problem

On non-en-US pages, {{CSSXref}} doesn't add parentheses in the displayed link texts for CSS functions.

Solution

As the page-type front matter key is absent from l10n contents, this PR uses en-US links to fetch the key instead.


How did you test this change?

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label May 18, 2023
@yarusome yarusome marked this pull request as ready for review May 18, 2023 10:11
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you! sorry for the delay reviewing this

@LeoMcA LeoMcA merged commit 7330766 into mdn:main Jul 11, 2023
@yarusome yarusome deleted the cssxref-locale branch July 12, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{{CSSXref}} fails to add parentheses for CSS functions
2 participants