Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-CN: Translate hypot() #13300

Merged
merged 3 commits into from
May 18, 2023
Merged

zh-CN: Translate hypot() #13300

merged 3 commits into from
May 18, 2023

Conversation

yarusome
Copy link
Contributor

Description

Motivation

Additional details

CSS 颜色模块翻译工作因英文版内容更新进度受阻而暂停。

Related issues and pull requests

@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label May 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023 •
edited
Loading

Preview URLs

Flaws (1)

URL: /zh-CN/docs/Web/CSS/hypot
Title: hypot()
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (4 in common of 6 possible)

(comment last updated: 2023-05-18 03:54:02)

@yarusome yarusome marked this pull request as ready for review May 18, 2023 02:33
@yarusome yarusome requested a review from a team as a code owner May 18, 2023 02:33
@yarusome yarusome requested review from jasonren0403 and removed request for a team May 18, 2023 02:33
jasonren0403
jasonren0403 reviewed May 18, 2023
View reviewed changes
files/zh-cn/web/css/hypot/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/hypot/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/css/hypot/index.md Outdated Show resolved Hide resolved
@jasonren0403
Copy link
Contributor

jasonren0403 commented May 18, 2023 •
edited
Loading

有个好奇的地方：
image

🤔 这两个地方我对照markdown源码检查了半天发现没啥区别，为啥会出现一边有括号一边没括号的情况

Edit：可能是对cssxref宏处理的问题，本地化时可能需要第二个参数来指定显示

@jasonren0403 jasonren0403 merged commit bb51d24 into mdn:main May 18, 2023
@yarusome yarusome deleted the hypot branch May 18, 2023 07:55
@yarusome
Copy link
Contributor Author

可能是对cssxref宏处理的问题，本地化时可能需要第二个参数来指定显示

{{CSSXref}} 通过获取页面的 page-title 判定当前页面是否为 CSS 函数页面，但是本地化页面没有这一项。我在 yari 开了合并请求 mdn/yari#8884 ，希望在不久的将来可以合并…… @jasonren0403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonren0403 jasonren0403 jasonren0403 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yarusome @jasonren0403