-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add xyz-build #8661
feat(ci): add xyz-build #8661
Conversation
fd959c9
to
664ad92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggested change is my one real concern, everything else is nits/can be discussed and fixed later
# Placement | ||
REACT_APP_PLACEMENT_ENABLED: true | ||
|
||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point it might be good to turn steps like this into shell scripts to: reduce duplication across workflows, and allow running things locally more easily
Co-authored-by: Leo McArdle <[email protected]>
Summary
(Extracted from #8366.)
Problem
Previously, we only had one test environment (
stage
), but this means we often have to wait for each other to "test on stage".Solution
Add another environment
xyz
and axyz-build
workflow similar tostage-build
.Note: The
xyz
environment does not have a dedicated rumba, so it doesn't currently support logging in.How did you test this change?
Will run another xyz build now.