Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add xyz-build #8661

Merged
merged 9 commits into from
May 12, 2023
Merged

feat(ci): add xyz-build #8661

merged 9 commits into from
May 12, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 17, 2023

Summary

(Extracted from #8366.)

Problem

Previously, we only had one test environment (stage), but this means we often have to wait for each other to "test on stage".

Solution

Add another environment xyz and a xyz-build workflow similar to stage-build.

Note: The xyz environment does not have a dedicated rumba, so it doesn't currently support logging in.


How did you test this change?

Will run another xyz build now.

@caugner caugner temporarily deployed to xyz April 20, 2023 10:29 — with GitHub Actions Inactive
@caugner caugner temporarily deployed to xyz April 20, 2023 10:34 — with GitHub Actions Inactive
@caugner caugner force-pushed the xyz-env branch 3 times, most recently from fd959c9 to 664ad92 Compare May 11, 2023 18:57
@caugner caugner marked this pull request as ready for review May 11, 2023 19:02
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggested change is my one real concern, everything else is nits/can be discussed and fixed later

.github/workflows/xyz-build.yml Outdated Show resolved Hide resolved
.github/workflows/xyz-build.yml Show resolved Hide resolved
.github/workflows/xyz-build.yml Show resolved Hide resolved
.github/workflows/xyz-build.yml Show resolved Hide resolved
# Placement
REACT_APP_PLACEMENT_ENABLED: true

run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point it might be good to turn steps like this into shell scripts to: reduce duplication across workflows, and allow running things locally more easily

.github/workflows/xyz-build.yml Outdated Show resolved Hide resolved
@caugner caugner temporarily deployed to xyz May 12, 2023 14:04 — with GitHub Actions Inactive
@caugner caugner changed the title ci: add xyz-build feat(ci): add xyz-build May 12, 2023
@caugner caugner merged commit 77df4fc into main May 12, 2023
@caugner caugner deleted the xyz-env branch May 12, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants