Skip to content

Commit

Permalink
feat(sidebar): add filter (#8968)
Browse files Browse the repository at this point in the history
Adds a filter field that allows users to quickly filter the sidebar.

When focusing the field, a feedback prompt with thumbs up/down
buttons appears below the input field, which we keep for 2-3 weeks.
Once feedback is given, the prompt does no longer appear for a user.

When filtering, the number of matches is shown inside the input field,
and only matching sidebar items (along with their parents and section 
heading, if exists) are shown, with the text matches being highlighted.

This includes three measurements to evaluate the feature:
1. We measure how many users focus the filter field.
2. We measure user sentiment through the thumbs feedback.
3. We measure how many filtered sidebar items are clicked.

Co-authored-by: Leo McArdle <[email protected]>
  • Loading branch information
caugner and LeoMcA authored Jun 8, 2023
1 parent 36b2372 commit 3a4c28d
Show file tree
Hide file tree
Showing 16 changed files with 807 additions and 13 deletions.
3 changes: 3 additions & 0 deletions client/src/assets/icons/filter.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 1 addition & 2 deletions client/src/document/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -651,8 +651,7 @@ kbd {
.sidebar {
mask-image: linear-gradient(
to bottom,
rgba(0, 0, 0, 0) 0%,
rgb(0, 0, 0) 3rem calc(100% - 3rem),
rgb(0, 0, 0) 0% calc(100% - 3rem),
rgba(0, 0, 0, 0) 100%
);
}
Expand Down
255 changes: 255 additions & 0 deletions client/src/document/organisms/sidebar/SidebarFilterer.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,255 @@
import { splitQuery } from "../../../utils";

export class SidebarFilterer {
allHeadings: HTMLElement[];
allParents: HTMLDetailsElement[];
items: Array<{
haystack: string;
link: HTMLAnchorElement;
container: HTMLElement;
heading: HTMLElement | undefined;
parents: HTMLDetailsElement[];
}>;
toc: HTMLElement | null;

constructor(root: HTMLElement) {
this.allHeadings = Array.from(
root.querySelectorAll<HTMLElement>("li strong")
);
this.allParents = Array.from(
root.querySelectorAll<HTMLDetailsElement>("details")
);

const links = Array.from(
root.querySelectorAll<HTMLAnchorElement>("a[href]")
);

this.items = links.map((link) => ({
haystack: (link.textContent ?? "").toLowerCase(),
link,
container: this.getContainerOf(link),
heading: this.getHeadingOf(link),
parents: this.getParentsOf(link),
}));

this.toc =
root.closest<HTMLElement>(".sidebar")?.querySelector(".in-nav-toc") ??
null;
}

applyFilter(query: string) {
if (query) {
this.toggleTOC(false);
return this.showOnlyMatchingItems(query);
} else {
this.toggleTOC(true);
this.showAllItems();
return undefined;
}
}

private toggleTOC(show: boolean) {
if (this.toc) {
this.toggleElement(this.toc, show);
}
}

private toggleElement(el: HTMLElement, show: boolean) {
el.style.display = show ? "" : "none";
}

showAllItems() {
this.items.forEach(({ link }) => this.resetLink(link));
this.allHeadings.forEach((heading) => this.resetHeading(heading));
this.allParents.forEach((parent) => this.resetParent(parent));
}

private resetLink(link: HTMLAnchorElement) {
this.resetHighlighting(link);
const container = this.getContainerOf(link);
this.toggleElement(container, true);
}

private getContainerOf(el: HTMLElement) {
return el.closest("li") || el;
}

private resetHeading(heading: HTMLElement) {
const container = this.getContainerOf(heading);
this.toggleElement(container, true);
}

private resetParent(parent: HTMLDetailsElement) {
const container = this.getContainerOf(parent);
this.toggleElement(container, true);
if (parent.dataset.wasOpen) {
parent.open = JSON.parse(parent.dataset.wasOpen);
delete parent.dataset.wasOpen;
}
}

private resetHighlighting(link: HTMLAnchorElement) {
const nodes = Array.from(link.querySelectorAll<HTMLElement>("span, mark"));
const parents = new Set<HTMLElement>();
nodes.forEach((node) => {
const parent = node.parentElement;
node.replaceWith(document.createTextNode(node.textContent ?? ""));
if (parent) {
parents.add(parent);
}
});
parents.forEach((parent) => parent.normalize());
}

showOnlyMatchingItems(query: string) {
this.allHeadings.forEach((heading) => this.hideHeading(heading));
this.allParents.forEach((parent) => this.collapseParent(parent));

// Show/hide items (+ show parents).
const terms = splitQuery(query);
let matchCount = 0;
this.items.forEach(({ haystack, link, container, heading, parents }) => {
this.resetHighlighting(link);
const isMatch = terms.every((needle) => haystack.includes(needle));

this.toggleElement(container, isMatch);

if (isMatch) {
matchCount++;
this.highlightMatches(link, terms);
if (heading) {
this.showHeading(heading);
}
for (const parent of parents) {
this.expandParent(parent);
}
}
});

return matchCount;
}

private hideHeading(heading: HTMLElement) {
const container = this.getContainerOf(heading);
this.toggleElement(container, false);
}

private collapseParent(parent: HTMLDetailsElement) {
const container = this.getContainerOf(parent);
this.toggleElement(container, false);
parent.dataset.wasOpen = parent.dataset.wasOpen ?? String(parent.open);
parent.open = false;
}

private highlightMatches(el: HTMLElement, terms: string[]) {
const nodes = this.getTextNodesOf(el);

nodes.forEach((node) => {
const haystack = node.textContent?.toLowerCase();
if (!haystack) {
return;
}

const ranges = new Map<number, number>();
terms.forEach((needle) => {
const index = haystack.indexOf(needle);
if (index !== -1) {
ranges.set(index, index + needle.length);
}
});
const sortedRanges = Array.from(ranges.entries()).sort(
([x1, y1], [x2, y2]) => x1 - x2 || y1 - y2
);

const span = this.replaceChildNode(node, "span");
span.className = "highlight-container";

let rest = span.childNodes[0] as Node & Text;
let cursor = 0;

for (const [rangeBegin, rangeEnd] of sortedRanges) {
if (rangeBegin < cursor) {
// Just ignore conflicting range.
continue;
}

// Split.
const match = rest.splitText(rangeBegin - cursor);
const newRest = match.splitText(rangeEnd - rangeBegin);

// Convert text node to HTML element.
this.replaceChildNode(match, "mark");

rest = newRest as Element & Text;
cursor = rangeEnd;
}
});
}

private getTextNodesOf(node: Node): (Node & Text)[] {
const parents = [node];
const nodes: (Node & Text)[] = [];

for (const parent of parents) {
for (const childNode of parent.childNodes) {
if (childNode.nodeType === Node.TEXT_NODE) {
nodes.push(childNode as Node & Text);
} else if (childNode.hasChildNodes()) {
parents.push(childNode);
}
}
}

return nodes;
}

private replaceChildNode(node: ChildNode, tagName: string) {
const text = node.textContent;
const newNode = document.createElement(tagName);
newNode.innerText = text ?? "";
node.replaceWith(newNode);
return newNode;
}

private showHeading(heading: HTMLElement) {
const container = heading && this.getContainerOf(heading);
if (container) {
this.toggleElement(container, true);
}
}

private getHeadingOf(el: HTMLElement) {
return this.findFirstElementBefore(el, this.allHeadings);
}

private findFirstElementBefore(el: HTMLElement, candidates: HTMLElement[]) {
return candidates
.slice()
.reverse()
.find(
(candidate) =>
candidate.compareDocumentPosition(el) &
Node.DOCUMENT_POSITION_FOLLOWING
);
}

private expandParent(parent: HTMLDetailsElement) {
const container = this.getContainerOf(parent);
this.toggleElement(container, true);
parent.open = true;
}

private getParentsOf(el: HTMLElement) {
const parents: HTMLDetailsElement[] = [];
let parent = el.parentElement?.closest("details");

while (parent) {
if (parent instanceof HTMLDetailsElement) {
parents.push(parent);
}
parent = parent.parentElement?.closest("details");
}

return parents;
}
}
Loading

0 comments on commit 3a4c28d

Please sign in to comment.