Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image files for "Animations basiques" #3267

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Add image files for "Animations basiques" #3267

merged 2 commits into from
Dec 6, 2021

Conversation

cw118
Copy link
Member

@cw118 cw118 commented Dec 4, 2021

Add missing image files for interactive examples in the Canvas API "Animations basiques" page

Fixes #3266

@cw118 cw118 requested a review from a team as a code owner December 4, 2021 21:52
@cw118 cw118 requested review from SphinxKnight and removed request for a team December 4, 2021 21:52
@github-actions github-actions bot added the l10n-fr Issues related to French content. label Dec 4, 2021
@cw118
Copy link
Member Author

cw118 commented Dec 6, 2021

Hello, I've been notified of an error with the PR review companion:

Unhandled error: Error: No matched build artifacts. Perhaps nothing built in the "PR test" workflow

I'm still quite new to the MDN web docs, especially the translated content, so I'm not sure about how/what to do to fix this issue. I'm also not very familiar with the way embedded live samples work and I have a feeling the changes I'm trying to make are more complex than they seem.

Are there any fixes I can help make or would it be better to close this PR?

@SphinxKnight
Copy link
Member

hello @cw118 thanks for the fix, I'll look at this on a local environment. Please don't worry too much about the error from PR Companion (follow up on mdn/yari#4972 )

@SphinxKnight
Copy link
Member

@cw118 Thanks again for this, I've pushed another commit in the doc to remove the "side by side comparaison" which is missing an actual screenshot and, most importantly, is not even in the English doc.
Regarding the "complexity" of this, normally, translated-content resolves assets by fallbacking on mdn/content (e.g. finding an image if it's not in the translated-content tree). However this is not true for EmbedLiveSample embedded resources (i.e. assets which are used in scripts in code samples)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

Preview URLs

Flaws

URL: /fr/docs/Web/API/Canvas_API/Tutorial/Basic_animations
Title: Animations basiques
on GitHub
Flaw count: 12

  • macros:
    • /fr/docs/Web/API/CanvasPattern does not exist but fallbacked on /en-US/docs/Web/API/CanvasPattern
    • /fr/docs/Web/API/ImageBitmap does not exist but fallbacked on /en-US/docs/Web/API/ImageBitmap
    • /fr/docs/Web/API/Path2D does not exist but fallbacked on /en-US/docs/Web/API/Path2D
    • /fr/docs/Web/API/Window/setInterval does not exist but fallbacked on /en-US/docs/Web/API/setInterval
    • /fr/docs/Web/API/Window/setTimeout does not exist but fallbacked on /en-US/docs/Web/API/setTimeout
    • and 2 more flaws omitted
  • broken_links:
    • Can't resolve /fr/docs/Tutoriel_canvas/Advanced_animations
    • Can't resolve /fr/docs/Jeux/Anatomie
    • Can't resolve /fr/docs/Jeux
    • Can't resolve /fr/docs/Un_raycaster_basique_avec_canvas
  • translation_differences:
    • Differences in the important macros (1 in common of 8 possible)

External URLs

URL: /fr/docs/Web/API/Canvas_API/Tutorial/Basic_animations
Title: Animations basiques
on GitHub

No new external URLs

Copy link
Member

@SphinxKnight SphinxKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SphinxKnight SphinxKnight merged commit 9be51f1 into mdn:main Dec 6, 2021
@cw118
Copy link
Member Author

cw118 commented Dec 6, 2021

I see, thank you so much for taking the time to explain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "Animations basiques": missing images
2 participants