-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image files for "Animations basiques" #3267
Conversation
Hello, I've been notified of an error with the PR review companion:
I'm still quite new to the MDN web docs, especially the translated content, so I'm not sure about how/what to do to fix this issue. I'm also not very familiar with the way embedded live samples work and I have a feeling the changes I'm trying to make are more complex than they seem. Are there any fixes I can help make or would it be better to close this PR? |
hello @cw118 thanks for the fix, I'll look at this on a local environment. Please don't worry too much about the error from PR Companion (follow up on mdn/yari#4972 ) |
@cw118 Thanks again for this, I've pushed another commit in the doc to remove the "side by side comparaison" which is missing an actual screenshot and, most importantly, is not even in the English doc. |
Preview URLsFlawsURL:
External URLsURL: No new external URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I see, thank you so much for taking the time to explain! |
Add missing image files for interactive examples in the Canvas API "Animations basiques" page
Fixes #3266