Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: update translation of debugger statement #18945

Merged
merged 6 commits into from
Apr 1, 2024
Merged

[zh-cn]: update translation of debugger statement #18945

merged 6 commits into from
Apr 1, 2024

Conversation

T34-active
Copy link
Contributor

Description

Motivation

Additional details

Related issues and pull requests

@T34-active T34-active requested a review from a team as a code owner March 25, 2024 07:38
@T34-active T34-active requested review from t7yang and removed request for a team March 25, 2024 07:38
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024 •
edited
Loading

Preview URLs

External URLs (1)

URL: /zh-CN/docs/Web/JavaScript/Reference/Statements/debugger
Title: debugger

(comment last updated: 2024-03-26 03:18:34)

@T34-active T34-active requested a review from yin1999 March 25, 2024 10:27
@jasonren0403 jasonren0403 mentioned this pull request Mar 25, 2024
Closed
JasonLamv-t
JasonLamv-t reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@JasonLamv-t JasonLamv-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for your reference.

@T34-active
Copy link
Contributor Author

Some suggestions for your reference.

Thank you for the advice you've given me. You've been a great help.👍

JasonLamv-t
JasonLamv-t reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@JasonLamv-t JasonLamv-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wrong, I just noticed @yin1999 's comment and I think it was correct, or we should create a PR upstream for more accuracy.

JasonLamv-t
JasonLamv-t approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@JasonLamv-t JasonLamv-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! @T34-active 👍🏼

@JasonLamv-t JasonLamv-t enabled auto-merge (squash) March 26, 2024 03:37
@yin1999 yin1999 disabled auto-merge March 26, 2024 05:44
yin1999
yin1999 reviewed Mar 26, 2024
View reviewed changes
files/zh-cn/web/javascript/reference/statements/debugger/index.md
@@ -38,4 +42,4 @@ function potentiallyBuggyCode() {

## 参见

- [在火狐开发者工具中调试](https://firefox-source-docs.mozilla.org/devtools-user/debugger/index.html)
- Firefox 源代码文档中的 [Firefox JavaScript 调试器](https://firefox-source-docs.mozilla.org/devtools-user/debugger/index.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the upstream content first: https://github.com/mdn/content/blob/f33c6e8a7204272b90d8f005f3d8c743333d7dbf/files/en-us/web/javascript/reference/statements/debugger/index.md?plain=1#L49

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the upstream content first: https://github.com/mdn/content/blob/f33c6e8a7204272b90d8f005f3d8c743333d7dbf/files/en-us/web/javascript/reference/statements/debugger/index.md?plain=1#L49

英文文档pull request：#32839

Copy link
Contributor Author

@T34-active T34-active Mar 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yin1999 在评论中回答我的问题了 你可以去看看

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按我的理解，这个符号是在复制标题时复制到的，在其他引用 firefox-source-docs.mozilla.org 的文档中，并未出现该符号。（可参考 PR：mdn/content#28668）

2024-03-26.18-00-38.mp4

Copy link
Contributor Author

@T34-active T34-active Mar 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在#32839评论中说，这里说是有意添加
commit：#a71b892

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在#32839评论中说，这里说是有意添加 commit：#a71b892

我看到了，bsmth 并未反对你的修改，只是补充了一条说明，你可以在 content 仓库中搜索该符号，目前只有两处是有这个符号的。

@yin1999 yin1999 added the needs content update Needs update to the content to support this change. label Mar 26, 2024
@yin1999 yin1999 changed the title [zh-CN]: update translation of debugger statement [zh-cn]: update translation of debugger statement Mar 26, 2024
@JasonLamv-t
Copy link
Member

Is there any new consensus? Should we reopen the PR upstream or merge this PR?

yin1999
yin1999 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢，先不管上游吧

@yin1999 yin1999 merged commit f3ea228 into mdn:main Apr 1, 2024
7 checks passed
@T34-active T34-active deleted the debugger branch April 1, 2024 03:19
@yin1999 yin1999 removed the needs content update Needs update to the content to support this change. label Apr 1, 2024
ciyoe pushed a commit to ciyoe/translated-content that referenced this pull request Apr 20, 2024
@T34-active @yin1999
@JasonLamv-t @ciyoe
[zh-cn]: update translation of debugger statement (mdn#18945)
8b1a2b7 
Co-authored-by: A1lo <[email protected]>
Co-authored-by: Jason Lam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

@t7yang t7yang Awaiting requested review from t7yang t7yang is a code owner automatically assigned from mdn/yari-content-zh

@JasonLamv-t JasonLamv-t Awaiting requested review from JasonLamv-t

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@T34-active @JasonLamv-t @yin1999