Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Update ray() syntax and add values #700

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Conversation

dipikabh
Copy link
Contributor

@dipikabh dipikabh commented Jan 5, 2024

Description

  • Fixes ray-size doesn't have a definition #676
    To address listing the values for <ray-size>, I've referred to the instructions in the mdn/data/docs section Store the information in the JSONs, where it mentions how to handle when "syntax contains references to specific values".

    I've added "syntaxes" for ray() in syntaxes.json. I've included only the keys that have further values. I'm not sure if that's the correct way to do it though. I am assuming this should be okay because the complete syntax exists in functions.json.

    UPDATE: "syntaxes" is not supported, was getting lint errors. I've reverted to use syntax but expanded the <ray-size> and <position> values inline.

  • I'm also using this PR to update ray() function syntax (mdn/content PR to add Formal syntax). With Firefox122 coming out on Jan 23, 2024, ray() will be supported by default, making it standard across browsers. So I've also updated the status to standard (BCD PR with ray() status update).

Motivation

Addressing an issue as well as updating the syntax

Related issues and pull requests

mdn/browser-compat-data#21844
mdn/content#31514

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 34ce070 into mdn:main Jan 6, 2024
3 checks passed
@dipikabh
Copy link
Contributor Author

dipikabh commented Jan 8, 2024

Thanks for reviewing, @teoli2003!

@dipikabh dipikabh deleted the ray-size branch January 8, 2024 17:20
@pyoor pyoor mentioned this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ray-size doesn't have a definition
2 participants