Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A kitchensink page #8

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Sep 17, 2020

Part of #7

I'll share more about how I built this later.

Can you please review the macros used and think of some that aren't used? @schalkneethling @escattone

@peterbe
Copy link
Contributor Author

peterbe commented Sep 18, 2020

@schalkneethling The worse thing is that one can't include more than one <div id="Quick_Links"> so there's no way to include all the various sidebars. One option for that would be to make one kitchensink page for every sidebar macro :(
Can you think of any other type of element that you have to keep an eye on when working on Fiori?
My goal here is that you (apart from the lack of various sidebars) just need to open this one page to check that your document SCSS fixes all the things possible.

@schalkneethling
Copy link

schalkneethling commented Sep 18, 2020

The worse thing is that one can't include more than one <div id="Quick_Links"> so there's no way to include all the various sidebars. One option for that would be to make one kitchensink page for every sidebar macro

That is what Storybook is for 😄 We can create different variations by providing different input to the RenderSidebar component.

@peterbe
Copy link
Contributor Author

peterbe commented Sep 18, 2020

The worse thing is that one can't include more than one <div id="Quick_Links"> so there's no way to include all the various sidebars. One option for that would be to make one kitchensink page for every sidebar macro

That is what Storybook is for 😄 We can create different variations by providing different input to the RenderSidebar component.

Yes and no. You can only do components in Storybook. I.e. TS code things in the src/.
There are a bunch of HTML things that only appear in the content either has hardcoded HTML or as KS macros.

Copy link

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@schalkneethling schalkneethling merged commit 10e921d into mdn:main Sep 23, 2020
@peterbe peterbe deleted the 7-a-kitchensink-page branch September 24, 2020 12:42
Josh-Cena added a commit that referenced this pull request Aug 8, 2022
…19191)

* Use arrow functions

* const

* Spaces

* Spaces

* Spaces

* spaces

* spaces

* Space

* Add comment

* spaces

* syntax + comments

* indent

* indent + this

* indent + this

* const + for...of

* Revert to innerHTML

* clean

* remove Hungarian notation + indent

* let -> const

* Indent

* fix indent

* shorten string

* indent

* indent

* Fix indent

* Fix indent

* Fix indent

* Fix indent

* Fix indent

* Fix indent

* Fix indent

* Fix indent

* Fix indent

* Fix indent + template strings

* Fix indent

* Fix indent

* Fix indent

* indent - Hungarian notation

* Fix indentation

* Fix spaces

* Update index.md

* Update files/en-us/web/api/web_audio_api/simple_synth/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/web_audio_api/simple_synth/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/web_audio_api/simple_synth/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/web_audio_api/using_iir_filters/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/web_audio_api/using_iir_filters/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/web_audio_api/web_audio_spatialization_basics/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update index.md

* Update files/en-us/web/api/web_workers_api/using_web_workers/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/web_speech_api/using_the_web_speech_api/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/web_workers_api/using_web_workers/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/web_workers_api/using_web_workers/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/web_workers_api/using_web_workers/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/webgl_api/by_example/hello_glsl/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/websockets_api/writing_websocket_server/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Revert over-correction

* Update files/en-us/web/api/webrtc_api/signaling_and_video_calling/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Remove extraneous brace

* Update files/en-us/web/api/webrtc_api/signaling_and_video_calling/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/api/webrtc_api/signaling_and_video_calling/index.md

Co-authored-by: Joshua Chen <[email protected]>

* small improvement

* Update files/en-us/web/api/window/location/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Remove Hungarian left-over

* Update files/en-us/web/api/window/location/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Fix logs

* add parentheses

* Update index.md

* Update index.md

* Changes

Co-authored-by: Joshua Chen <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants