Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BCD from guide pages #4594

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Apr 29, 2021

See #4574 (comment)

I think these guide pages talk about a variety of features and the compat data included isn't very suitable there. The relevant reference pages are linked heavily and that's where the reader typically finds compat / spec information.

@Elchi3 Elchi3 requested a review from a team as a code owner April 29, 2021 10:27
@Elchi3 Elchi3 requested review from wbamberg and removed request for a team April 29, 2021 10:27
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/JavaScript/Typed_arrays
Title: JavaScript typed arrays
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Code_snippets/StringView
    • http:// external links are not allowed (will be forced to https:// at build-time)

URL: /en-US/docs/Web/JavaScript/Guide/Regular_Expressions
Title: Regular expressions
on GitHub
Flaw count: 1

  • broken_links:
    • No need for the pathname in anchor links if it's the same page

External URLs

URL: /en-US/docs/Web/JavaScript/Typed_arrays
Title: JavaScript typed arrays
on GitHub


URL: /en-US/docs/Web/JavaScript/Guide/Regular_Expressions
Title: Regular expressions
on GitHub

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @Elchi3 !

@wbamberg wbamberg merged commit 3f5a809 into mdn:main Apr 29, 2021
@Elchi3 Elchi3 deleted the rm-bcd-from-guide-pages branch April 29, 2021 15:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants