Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear that linebreaks is allowed in textareas #37229

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ksmadsen
Copy link
Contributor

Description

Change the note about linefeeds in placeholder attributes, to make it clear that it doesn't apply to textarea fields.

Motivation

When skimming the placeholder page, it is easy to come to the conclusion that linebreaks aren't allowed in the placeholder attribute, even on textareas. The only concession to this fact is otherwise in the compatibility chart, where it is easy to overlook.

When skimming the placeholder page, it is easy to come to the conclusion that linebreaks aren't allowed in placeholders, even on textareas. In fact the only concession to this fact is in the compatibility chart.

So change the note text a bit to make this clearer.
@ksmadsen ksmadsen requested a review from a team as a code owner December 16, 2024 12:42
@ksmadsen ksmadsen requested review from estelle and removed request for a team December 16, 2024 12:42
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed labels Dec 16, 2024
Copy link
Contributor

Preview URLs

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I didn't even know this!
Also, congratulations on your first merged MDN content PR. Welcome to the team!

@estelle estelle merged commit 095b93e into mdn:main Dec 16, 2024
7 checks passed
@ksmadsen ksmadsen deleted the patch-1 branch December 17, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants