Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes two live samples #37105

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fixes two live samples #37105

merged 1 commit into from
Dec 5, 2024

Conversation

argl
Copy link
Contributor

@argl argl commented Dec 5, 2024

Description

Fixes a problem with two live samples, as reported here.

Motivation

Fix the live samples

Additional details

Sample code needs some special escaping in this edge case.

Related issues and pull requests

Fixes mdn/yari#12215

@github-actions github-actions bot added the Content:Learn:JavaScript Learning area JavaScript docs label Dec 5, 2024
@argl argl marked this pull request as ready for review December 5, 2024 09:45
@argl argl requested a review from a team as a code owner December 5, 2024 09:45
@argl argl requested review from Josh-Cena and removed request for a team December 5, 2024 09:45
@github-actions github-actions bot added the size/xs [PR only] 0-5 LoC changed label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏻

@argl argl merged commit 94982f7 into main Dec 5, 2024
8 checks passed
@argl argl deleted the MP-1792-fix-live-sample branch December 5, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:JavaScript Learning area JavaScript docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The live samples in some documents seem to be broken
2 participants