-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebExt: fix typo #37091
Merged
Merged
WebExt: fix typo #37091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebExt
WebExtensions docs
size/xs
[PR only] 0-5 LoC changed
labels
Dec 4, 2024
Preview URLs (comment last updated: 2024-12-16 04:11:46) |
github-actions
bot
added
size/s
[PR only] 6-50 LoC changed
and removed
size/xs
[PR only] 0-5 LoC changed
labels
Dec 4, 2024
files/en-us/mozilla/add-ons/webextensions/api/management/uninstall/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tall/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Dec 9, 2024
rebloor
requested changes
Dec 16, 2024
files/en-us/mozilla/add-ons/webextensions/api/management/uninstall/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/api/management/uninstall/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: rebloor <[email protected]>
rebloor
approved these changes
Dec 16, 2024
Thanks @PassionPenguin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a typo
a the ID of a different add-on
;under
## Examples
line 2 (L49 of file), sentence writtenNote that we haven't passed a fulfillment handler because if uninstallation succeeds, the add-on is no longer around to handle it.
; *but that's not factually correct if we are uninstalling different add-on(s) than the one that's calling the method, than shouldn't the add-on is still here to handle it?per tested, fulfillment handler are called when the add-on/extension is uninstalled.
FYI: content was here ever since it's checkin into git.