Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebExt: fix typo #37091

Merged
merged 7 commits into from
Dec 16, 2024
Merged

WebExt: fix typo #37091

merged 7 commits into from
Dec 16, 2024

Conversation

PassionPenguin
Copy link
Contributor

@PassionPenguin PassionPenguin commented Dec 4, 2024

  1. fixed a typo a the ID of a different add-on;

  2. under ## Examples line 2 (L49 of file), sentence written Note that we haven't passed a fulfillment handler because if uninstallation succeeds, the add-on is no longer around to handle it.; *but that's not factually correct if we are uninstalling different add-on(s) than the one that's calling the method, than shouldn't the add-on is still here to handle it?

    per tested, fulfillment handler are called when the add-on/extension is uninstalled.

    let id = "addon-id";
    
    const uninstall = () => {
        function onCanceled(error) {
            console.log(`Cancelled: ${error}`);
        }
    
        function onUninstalled() {
            console.log("Uninstalled");
        }
    
        let uninstalling = chrome.management.uninstall(id);
        uninstalling.then(onUninstalled, onCanceled);
    }

FYI: content was here ever since it's checkin into git.

@PassionPenguin PassionPenguin requested a review from a team as a code owner December 4, 2024 11:01
@PassionPenguin PassionPenguin requested review from jpmedley and removed request for a team December 4, 2024 11:01
@github-actions github-actions bot added Content:WebExt WebExtensions docs size/xs [PR only] 0-5 LoC changed labels Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Preview URLs

(comment last updated: 2024-12-16 04:11:46)

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Dec 4, 2024
PassionPenguin and others added 3 commits December 4, 2024 19:20
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tall/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@rebloor rebloor merged commit c9bad2e into mdn:main Dec 16, 2024
8 checks passed
@rebloor
Copy link
Contributor

rebloor commented Dec 16, 2024

Thanks @PassionPenguin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants