Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert to the new dot handling logic on jsxref #36663

Merged
merged 1 commit into from
Nov 5, 2024
Merged

convert to the new dot handling logic on jsxref #36663

merged 1 commit into from
Nov 5, 2024

Conversation

argl
Copy link
Contributor

@argl argl commented Nov 5, 2024

Description

Use the new jsxref dot handling logic. See see mdn/yari#11869
(MP-1708)

Motivation

rari/yari parity

@github-actions github-actions bot added the Content:JS JavaScript docs label Nov 5, 2024
@argl argl marked this pull request as ready for review November 5, 2024 16:08
@argl argl requested a review from a team as a code owner November 5, 2024 16:08
@argl argl requested review from Josh-Cena and removed request for a team November 5, 2024 16:08
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Preview URLs

bsmth
bsmth approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍🏻

@Josh-Cena Josh-Cena merged commit 65c47ca into main Nov 5, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the MP-1708-new-do-syntax-jsxref branch November 5, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner automatically assigned from mdn/yari-content-javascript

Assignees
No one assigned
Labels
Content:JS JavaScript docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@argl @bsmth @Josh-Cena