Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rari-relatede content fixes #36595

Merged
merged 3 commits into from
Oct 31, 2024
Merged

rari-relatede content fixes #36595

merged 3 commits into from
Oct 31, 2024

Conversation

argl
Copy link
Contributor

@argl argl commented Oct 31, 2024

Description

This clears a few rari-related deficiencies that were not surfacing under yari or broken in differrent ways. The Syntax for escaping macros is documented as "escaping the first opening brace", this normalizes a few variants of that.

Also removed a sidebar macro from the kitchensink that is incompatible with the way rari handles sidebars. The macro has kitchensink-special-treatment in yari with no rari equivalent possible.

Motivation

rari / yari parity

@github-actions github-actions bot added Content:Learn Learning area docs Content:Learn:Django Learning area Django docs Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Meta Content in the meta docs size/s [PR only] 6-50 LoC changed labels Oct 31, 2024
@argl argl marked this pull request as ready for review October 31, 2024 17:14
@argl argl requested review from a team as code owners October 31, 2024 17:14
@argl argl requested review from hamishwillee and removed request for a team October 31, 2024 17:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

Preview URLs (6 pages)

(comment last updated: 2024-10-31 19:38:48)

dipikabh
dipikabh approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Thanks, @argl!
I've suggested a few other changes to the lines touched.

files/en-us/learn/server-side/django/introduction/index.md Show resolved Hide resolved
files/en-us/mdn/writing_guidelines/page_structures/macros/other/index.md Outdated Show resolved Hide resolved
@fiji-flo fiji-flo merged commit 41a27d6 into main Oct 31, 2024
9 checks passed
@fiji-flo fiji-flo deleted the MP-1696-content-fixes-for-rari branch October 31, 2024 19:44
@mfuji09 mfuji09 mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

@caugner caugner caugner left review comments

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-http

Assignees
No one assigned
Labels
Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Learn:Django Learning area Django docs Content:Learn Learning area docs Content:Meta Content in the meta docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@argl @caugner @dipikabh @fiji-flo