Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a guide page on XSS #36412
Add a guide page on XSS #36412
Changes from all commits
e93facd
89ce9d2
e1de7e1
16c7c39
1ff7634
f748a7e
bc9d568
d766304
98d8c46
d1cc8a6
7b22817
cc94a7b
aa93ef1
24055ee
0c3e5bc
eb795dc
dfdd004
60e75b7
943ebc0
45f5b54
ca92f5f
392c06d
e1f1f2a
1bada9d
fa40431
3234728
c3aa62f
4557801
4f095a1
eda47fc
658e2c4
a8de9b1
262b86c
190f86a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps forward reference that there are different types of attacks?
Not filling it in because of my following note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really want to do this, because I don't want to lean too heavily on the attack taxonomy below. "all attacks" doesn't just mean "all of the categories in that taxonomy" - for example, an attack that uses
<iframe src=
and one that uses<img onerror
and one that usesjavascript:
might all be the same type of attack according to our taxonomy, but they are different attacks, but all depend on these two conditions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I think my take on this was that if the types of attacks are useful then they should be mentioned earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but it would be nice if there was a glossary for "escaping text" or similar to link here.
We might perhaps use https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Regular_expressions/Character_escape
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's a very friendly page! Agree that a glossary page would be good -> #37206.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a pity the line break doesn't render in the bullet :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I agree, and thought the same thing when I wrote this! The really sad thing is, the markup is a separate paragraph, but for some unknown reason Yari's CSS applies a margin of zero for paragraphs in an
<li>
🤦 :There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave it to you go chase the yari team :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth including our own summary checklist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For everything? You mean something like:
? I think this is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't done this yet but will get to it tomorrow!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> 1bada9d