Fix code bug #36128
Merged
Fix code bug #36128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getSenders-function is never called, but just accessed as if it was a getter-property.
github-actions
bot
added
Content:WebAPI
pepelsbey
pushed a commit
to pepelsbey/mdn-content
that referenced
this pull request
Oct 1, 2024
fiji-flo
pushed a commit
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The getSenders-function is never called, but just accessed as if it was a getter-property. The proposed change correctly adds parentheses after "getSenders", so the method is properly called.
Motivation
So they won't make the same mistake I did :-)
Additional details
Link to definition of "getSenders" inn the RTCIceTransport-class. It's defined as a method, and not a property:
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/getSenders