Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix globals, part 16: clearInterval() & setInterval() #36042

Merged
merged 10 commits into from
Oct 4, 2024
Merged

Fix globals, part 16: clearInterval() & setInterval() #36042

merged 10 commits into from
Oct 4, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Sep 25, 2024 •
edited
Loading

Description

Motivation

Additional details

Related issues and pull requests

part of the #33019

/cc @wbamberg

@github-actions github-actions bot added Content:WebExt WebExtensions docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:Media Media docs Content:Learn:Accessibility Accessibility documentation in the Learn Area size/m [PR only] 51-500 LoC changed labels Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

Preview URLs (43 pages)
Flaws (32)

Note! 37 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/50
Title: Firefox 50 for developers
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/webkitGetEntries does not exist

URL: /en-US/docs/Mozilla/Firefox/Releases/51
Title: Firefox 51 for developers
Flaw count: 13

  • macros:
    • /en-US/docs/Web/API/MozSocial does not exist
    • /en-US/docs/Web/API/Navigator/mozSocial does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Projects/Necko/Proxy_Auto-Configuration_(PAC)_file
    • Can't resolve /en-US/docs/Archive/Firefox_OS/API/Simple_Push_API
    • Can't resolve /en-US/docs/Archive/Firefox_OS/API/Alarm_API
    • Can't resolve /en-US/docs/Mozilla/Add-ons/WebExtensions/Embedded_WebExtensions
    • Can't resolve /en-US/docs/Mozilla/Add-ons/Install_Manifests#multiprocesscompatible
    • and 6 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/5
Title: Firefox 5 for developers
Flaw count: 9

  • macros:
    • /en-US/docs/Web/API/SVGPathSegList does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Character_Sets_Supported_by_Gecko
    • Can't resolve /en-US/docs/Web/HTTP_access_control
    • Can't resolve /en-US/docs/Mozilla/Firefox/Updating_add-ons
    • Can't resolve /en-US/docs/Mozilla/Developer_guide/Interface_Compatibility#binary_interfaces
    • Can't resolve /en-US/docs/JavaScript_code_modules/Dict.jsm
    • and 3 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/56
Title: Firefox 56 for developers
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/formAction does not exist
    • /en-US/docs/Web/API/HTMLButtonElement/formAction does not exist
    • /en-US/docs/Web/API/HTMLElement/wheel_event does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Firefox/Headless_mode

URL: /en-US/docs/Mozilla/Firefox/Releases/13
Title: Firefox 13 for developers
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/FileError does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Gecko_user_agent_string_reference#mobile_and_tablet_indicators
    • Can't resolve /en-US/docs/Mozilla_MathML_Project/Fonts
    • Can't resolve /en-US/docs/Accessibility/AT-APIs/Gecko/Attrs

URL: /en-US/docs/Web/API/RTCIceCandidateStats/deleted
Title: RTCIceCandidateStats: deleted property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.RTCIceCandidateStats.deleted
External URLs (7)

URL: /en-US/docs/Mozilla/Firefox/Releases/50
Title: Firefox 50 for developers

URL: /en-US/docs/Mozilla/Firefox/Releases/56
Title: Firefox 56 for developers

URL: /en-US/docs/Mozilla/Firefox/Releases/55
Title: Firefox 55 for developers

URL: /en-US/docs/Web/JavaScript/JavaScript_technologies_overview
Title: JavaScript technologies overview

URL: /en-US/docs/Web/API/WorkerGlobalScope/setInterval
Title: WorkerGlobalScope: setInterval() method

URL: /en-US/docs/Web/API/Web_Workers_API/Using_web_workers
Title: Using Web Workers

(comment last updated: 2024-10-04 05:37:33)

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Sep 26, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Sep 27, 2024
@github-actions github-actions bot added Content:Learn Learning area docs Content:HTTP HTTP docs Content:Games Games docs Content:Performance Web performance docs Content:Learn:JavaScript Learning area JavaScript docs Content:Firefox Content in the Mozilla/Firefox subtree labels Sep 28, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review September 28, 2024 15:50
@skyclouds2001 skyclouds2001 requested review from a team as code owners September 28, 2024 15:50
@skyclouds2001 skyclouds2001 removed the request for review from a team September 28, 2024 15:50
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Sep 29, 2024
@Josh-Cena Josh-Cena requested review from wbamberg and removed request for a team, pepelsbey, dotproto, Elchi3 and scottaohara October 2, 2024 06:17
@skyclouds2001 skyclouds2001 requested a review from wbamberg October 4, 2024 05:10
wbamberg
wbamberg approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice work @skyclouds2001 . Only one more to go?

@wbamberg wbamberg merged commit b795bc9 into mdn:main Oct 4, 2024
9 checks passed
@skyclouds2001 skyclouds2001 deleted the interval branch October 4, 2024 06:30
@skyclouds2001
Copy link
Contributor Author

👍 nice work @skyclouds2001 . Only one more to go?

Yes

@yin1999 yin1999 mentioned this pull request Oct 5, 2024
Merged
yin1999 added a commit to mdn/translated-content that referenced this pull request Oct 5, 2024
@yin1999
zh-cn: resolve the global functions clearInterval() and `setInterva…
3043f33 
…l()`

ref: mdn/content#36042
yin1999 added a commit to mdn/translated-content that referenced this pull request Oct 5, 2024
@yin1999
zh-cn: resolve the global functions clearInterval() and `setInterva…
7c75e9e 
…l()`

ref: mdn/content#36042
yin1999 added a commit to mdn/translated-content that referenced this pull request Oct 5, 2024
@yin1999
zh-cn: resolve the global functions clearInterval() and `setInterva…
a7303c2 
…l()`

ref: mdn/content#36042
yin1999 added a commit to mdn/translated-content that referenced this pull request Oct 5, 2024
@yin1999
zh-cn: resolve the global function setInterval()
a37fc99 
ref: mdn/content#36042
yin1999 added a commit to mdn/translated-content that referenced this pull request Oct 5, 2024
@mdn-bot @yin1999
[zh-tw] sync translated content (#23912)
5280e5e 
* zh-tw: sync translated content

* zh-cn: resolve the global function `setInterval()`

ref: mdn/content#36042

---------

Co-authored-by: Allo <[email protected]>
sora32127 pushed a commit to sora32127/translated-content that referenced this pull request Oct 6, 2024
@yin1999 @sora32127
zh-cn: resolve the global functions clearInterval() and `setInterva…
69f3110 
…l()`

ref: mdn/content#36042
sora32127 pushed a commit to sora32127/translated-content that referenced this pull request Oct 6, 2024
@mdn-bot @yin1999 @sora32127
[zh-tw] sync translated content (mdn#23912)
3987273 
* zh-tw: sync translated content

* zh-cn: resolve the global function `setInterval()`

ref: mdn/content#36042

---------

Co-authored-by: Allo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:Games Games docs Content:HTTP HTTP docs Content:JS JavaScript docs Content:Learn:Accessibility Accessibility documentation in the Learn Area Content:Learn:JavaScript Learning area JavaScript docs Content:Learn Learning area docs Content:Media Media docs Content:Performance Web performance docs Content:WebAPI Web API docs Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @wbamberg