Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing info on the purpose of scrollbar-width property #35873

Merged
merged 6 commits into from
Sep 17, 2024
Merged

chore: add missing info on the purpose of scrollbar-width property #35873

merged 6 commits into from
Sep 17, 2024

Conversation

muchafm
Copy link
Contributor

@muchafm muchafm commented Sep 13, 2024 •
edited
Loading

Description

I saw this issue #35835 and thought about adding a small description to add more context to the purpose of the property.

Motivation

I've contributed in the past and want to continue when I can!

Additional details

Related issues and pull requests

It fixes #35835
Relates to #35835

@muchafm muchafm requested a review from a team as a code owner September 13, 2024 17:00
@muchafm muchafm requested review from estelle and removed request for a team September 13, 2024 17:00
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Sep 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-09-16 18:18:16)

estelle
estelle reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you suggested is important. I offered a suggestion that expands on it even further.

files/en-us/web/css/scrollbar-width/index.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Sep 13, 2024
@muchafm muchafm requested a review from estelle September 13, 2024 20:59
@OnkarRuikar
Copy link
Contributor

In the ## Values section, the table from the wiki era can be converted to a definition list. This is not related to the PR, but it would be great if it were done.

@muchafm
Copy link
Contributor Author

muchafm commented Sep 16, 2024

In the ## Values section, the table from the wiki era can be converted to a definition list. This is not related to the PR, but it would be great if it were done.

on it 🙂

@muchafm muchafm requested a review from OnkarRuikar September 16, 2024 18:16
@OnkarRuikar
Copy link
Contributor

Looks good to me.

estelle
estelle approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 57cfc73 into mdn:main Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@OnkarRuikar OnkarRuikar Awaiting requested review from OnkarRuikar

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing info about scrollbar-width intended use case
3 participants
@muchafm @OnkarRuikar @estelle