Permission API updates #35768
Merged
Permission API updates #35768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
hamishwillee
force-pushed
the
ff_permission_api_fixes
branch
from
cdda306 to
08fa67b
Compare
hamishwillee
commented
Sep 9, 2024
hamishwillee
commented
Sep 9, 2024
Comment on lines
-46
to
-50
| > [!NOTE] | ||
| > As of Firefox 44, the permissions for [Notifications](/en-US/docs/Web/API/Notifications_API) and [Push](/en-US/docs/Web/API/Push_API) have been merged. If permission is | ||
| > granted (e.g. by the user, in the relevant permissions dialog), | ||
| > `navigator.permissions.query()` will return `true` for both | ||
| > `notifications` and `push`. |
There was a problem hiding this comment.
FYI have pushed to BCD mdn/browser-compat-data#24359
hamishwillee
commented
Sep 9, 2024
hamishwillee
commented
Sep 9, 2024
| default state, which is usually `prompt`. | ||
| This method is called on the global {{domxref("Permissions")}} object | ||
| {{domxref("navigator.permissions")}}. | ||
| The **`revoke()`** method of the {{domxref("Permissions")}} interface reverts a currently set permission back to its default state, which is usually `prompt`. |
There was a problem hiding this comment.
We should delete this page IMO. Am asking on BCD how they feel: mdn/browser-compat-data#24359
EDIT - unfortunately it doesn't meet BCD guidelines for removal, even though this is not implemented except behind a flag.
hamishwillee
commented
Sep 9, 2024
hamishwillee
commented
Sep 9, 2024
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
bsmth
reviewed
Sep 19, 2024
bsmth
reviewed
Sep 19, 2024
bsmth
reviewed
Sep 19, 2024
bsmth
reviewed
Sep 19, 2024
bsmth
reviewed
Sep 19, 2024
| ## Examples | ||
|
|
||
| We have created a simple example called Location Finder. | ||
| You can [run the example live](https://chrisdavidmills.github.io/location-finder-permissions-api/), [view the source code on GitHub](https://github.com/chrisdavidmills/location-finder-permissions-api/tree/gh-pages), or read more about how it works in our article [Using the Permissions API](/en-US/docs/Web/API/Permissions_API/Using_the_Permissions_API). |
There was a problem hiding this comment.
note for us it's under chrisdavidmills.github.io
There was a problem hiding this comment.
Yeah, saw that. MOve ownership, or create a new repo with sub folders for different APIs?
bsmth
approved these changes
Sep 19, 2024
Co-authored-by: Brian Thomas Smith <[email protected]>
|
Thanks for review @bsmth - I've accepted all (or with slight modification). Merging now because I'm away for a week and this is good. |
fiji-flo
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Permission API updates * Update permissions with geolocation links * Fix watchposition bug * Get rid of the forward looking stuff * Tidy concepts * Apply suggestions from code review Co-authored-by: Brian Thomas Smith <[email protected]> --------- Co-authored-by: Brian Thomas Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "refresh" of the Permissions API docs. I'm doing it as part of looking at addition of
microphoneandcamerapermissions. The docs are a bit dated - they won't be perfect after this, but they will be better.The main change is to try to cut back some of the future looking behaviour that was written back when this was created. The story is now stable:
I also added a security considerations section for the Geolocation overview page. Next iteration of these docs I'd hope to perhaps do this for all the permission using APIs. From that I could add a list of things that cause the permission prompt to this doc.
Related docs work can be tracked in #35765