Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DataView to access WebAssembly memory #33960

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Use DataView to access WebAssembly memory #33960

merged 3 commits into from
Jun 7, 2024

Conversation

Josh-Cena
Copy link
Member

Fix #25569

@Josh-Cena Josh-Cena requested review from a team as code owners June 6, 2024 09:46
@Josh-Cena Josh-Cena requested review from teoli2003 and removed request for a team June 6, 2024 09:46
@github-actions github-actions bot added Content:JS JavaScript docs Content:wasm WebAssembly docs labels Jun 6, 2024
@Josh-Cena Josh-Cena mentioned this pull request Jun 6, 2024
Closed
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited
Loading

Preview URLs (6 pages)
External URLs (1)

URL: /en-US/docs/WebAssembly/JavaScript_interface/Memory
Title: WebAssembly.Memory

(comment last updated: 2024-06-07 04:46:22)

@Josh-Cena Josh-Cena force-pushed the dataview-wasm-mem branch from d2d2199 to b512881 Compare June 6, 2024 09:48
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Jun 6, 2024
@Josh-Cena Josh-Cena mentioned this pull request Jun 6, 2024
Merged
hamishwillee
hamishwillee approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A couple of arguable nits. Approving so you can self-merge if you disagree with them.

@Josh-Cena @github-actions
Update files/en-us/webassembly/javascript_interface/memory/memory/ind…
18a69f0 
…ex.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Josh-Cena
Copy link
Member Author

@hamishwillee There's also mdn/webassembly-examples#37 btw

@Josh-Cena Josh-Cena merged commit 58d3a9a into mdn:main Jun 7, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the dataview-wasm-mem branch June 7, 2024 04:46
bsmth pushed a commit to mdn/webassembly-examples that referenced this pull request Jun 7, 2024
@Josh-Cena @hamishwillee
Use DataView to access WebAssembly memory (#37)
1b53615 
Accompanying mdn/content#33960

---------

Co-authored-by: Hamish Willee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@hamishwillee hamishwillee hamishwillee approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003 teoli2003 is a code owner automatically assigned from mdn/yari-content-javascript

Assignees
No one assigned
Labels
Content:JS JavaScript docs Content:wasm WebAssembly docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessing WebAssembly memory using TypedArrays is incorrect on Big Endian systems
2 participants
@Josh-Cena @hamishwillee